Differential D26569

Provide a way to easily query which feedback options are available
ClosedPublic
Actions

Authored by apol on Jan 10 2020, 7:11 PM.

Details

Reviewers
vkrause
Group Reviewers
Plasma
Commits
R849:d65d6a41a006: Provide a way to easily query which feedback options are available
Summary

This will be useful to create better cross-process tools that expose the
required feedback information.

Test Plan

Implemented it in Plasma Shell and Discover, adopted the results in
the Feedback KCM for showing who uses what.

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol requested review of this revision.Jan 10 2020, 7:11 PM
apol created this revision.
vkrause added a comment.Jan 11 2020, 11:30 AM

I'm fine with the interface, but I'm unsure whether this is human or machine read? For human consumption we might want translated texts?

ngraham added a subscriber: ngraham.Jan 11 2020, 4:44 PM

I think the intention is for human consumption, yes. The intention is to improve the user's confidence in making an informed choice by showing exactly what will be sent.

apol added a comment.Jan 11 2020, 7:44 PM

See https://phabricator.kde.org/D26570, we definitely want translations. Should we use the description instead?

vkrause added a comment.Jan 12 2020, 11:06 AM
In D26569#592135, @apol wrote:

See https://phabricator.kde.org/D26570, we definitely want translations. Should we use the description instead?

name() is fine, IIRC that's translated, I'm more looking at the raw enum name used in front of it.

apol added a comment.Jan 14 2020, 12:12 PM
In D26569#592490, @vkrause wrote:
In D26569#592135, @apol wrote:

See https://phabricator.kde.org/D26570, we definitely want translations. Should we use the description instead?

name() is fine, IIRC that's translated, I'm more looking at the raw enum name used in front of it.

the enum name is processed into the kcm, we need to turn it into a number.

vkrause accepted this revision.Jan 14 2020, 12:14 PM

Ah ok, all good then :) Thanks!

This revision is now accepted and ready to land.Jan 14 2020, 12:14 PM
Closed by commit R849:d65d6a41a006: Provide a way to easily query which feedback options are available (authored by apol). · Explain WhyJan 14 2020, 3:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 73533

View Options

src/provider/core/provider.h

Loading...
View Options

src/provider/core/provider.cpp

Loading...