Differential D24726

Fix null pointer reference when extraction fails
ClosedPublic
Actions

Authored by pvuorela on Oct 17 2019, 10:28 AM.

Details

Reviewers
davidllewellynjones
dfaure
aacid
Commits
R243:8222caed9367: Fix null pointer reference when extraction fails

Diff Detail

Repository
R243 KArchive
Branch
upstream_master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18383
Build 18401: arc lint + arc unit
pvuorela created this revision.Oct 17 2019, 10:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 17 2019, 10:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
pvuorela requested review of this revision.Oct 17 2019, 10:28 AM
pvuorela updated this revision to Diff 69086.Oct 31 2019, 8:37 AM

Also remove the empty target file on error

apol added a subscriber: apol.Oct 31 2019, 1:40 PM

Have you looked into creating a unit test for this?

pvuorela added a comment.Oct 31 2019, 1:54 PM

Haven't looked and to be honest a little skeptical if anyone removing a null check is likely enough to protect against.

aacid accepted this revision.Oct 31 2019, 8:53 PM
This revision is now accepted and ready to land.Oct 31 2019, 8:53 PM
Closed by commit R243:8222caed9367: Fix null pointer reference when extraction fails (authored by pvuorela). · Explain WhyNov 1 2019, 7:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/karchive.cpp (4 lines)

Diff 69086

View Options

src/karchive.cpp

Loading...