Depends on D24928
Details
- Reviewers
dfaure vkrause - Maniphest Tasks
- T11544: Remove KTcpSocket
- Commits
- R241:f39eb884fecc: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)
make && ctest
Diff Detail
- Repository
- R241 KIO
- Branch
- ahmad/kio_http-ktcpsocket (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18136 Build 18154: arc lint + arc unit
This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.
Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this cast will always return a nullptr.
Anyway, I've started porting TcpSlaveBase. :)
Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).
I wasn't doubting the validity of what you said, just I didn't see it, until now :)
Anyway, I've started porting TcpSlaveBase. :)
Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).
Yep.