Differential D24873

[http kio slave] use QSslSocket instead of KTcpSocket (deprecated)
ClosedPublic
Actions

Authored by ahmadsamir on Oct 22 2019, 8:27 PM.

Details

Reviewers
dfaure
vkrause
Maniphest Tasks
T11544: Remove KTcpSocket
Commits
R241:f39eb884fecc: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)
Summary

Depends on D24928

Test Plan

make && ctest

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Oct 22 2019, 8:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 22 2019, 8:27 PM
ahmadsamir requested review of this revision.Oct 22 2019, 8:27 PM
vkrause added a comment.Oct 22 2019, 8:31 PM

This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.

ahmadsamir added a comment.Oct 23 2019, 1:01 PM
In D24873#552410, @vkrause wrote:

This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.

If you say so. Anyway, I've started porting TcpSlaveBase. :)

vkrause added a comment.Oct 23 2019, 4:09 PM
In D24873#552697, @ahmadsamir wrote:
In D24873#552410, @vkrause wrote:

This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.

If you say so.

Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this cast will always return a nullptr.

Anyway, I've started porting TcpSlaveBase. :)

Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).

ahmadsamir added a comment.Oct 23 2019, 6:45 PM
In D24873#552795, @vkrause wrote:
In D24873#552697, @ahmadsamir wrote:
In D24873#552410, @vkrause wrote:

This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.

If you say so.

Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this cast will always return a nullptr.

I wasn't doubting the validity of what you said, just I didn't see it, until now :)

Anyway, I've started porting TcpSlaveBase. :)

Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).

Yep.

vkrause accepted this revision.Nov 10 2019, 9:30 AM
This revision is now accepted and ready to land.Nov 10 2019, 9:30 AM
Closed by commit R241:f39eb884fecc: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated) (authored by ahmadsamir). · Explain WhyNov 10 2019, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/ioslaves/http/http.cpp (4 lines)

Diff 69517

View Options

src/ioslaves/http/http.cpp

Loading...