Differential D24597

[Konversation] Port from deprecated KTcpSocket to QSslSocket
ClosedPublic
Actions

Authored by ahmadsamir on Oct 12 2019, 4:48 PM.

Details

Reviewers
dvratil
vkrause
Group Reviewers
Konversation
Maniphest Tasks
T11577: Port Konversation away from KTcpSocket
Commits
R7:458822190452: [Konversation] Port from deprecated KTcpSocket to QSslSocket
Summary

Increase the min. required Qt version to 5.7.0 since that was the version
where QOverload was introduced.

Diff Detail

Repository
R7 Konversation
Branch
ahmad/ktcpsocket-qsslsocket (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17639
Build 17657: arc lint + arc unit
ahmadsamir requested review of this revision.Oct 12 2019, 4:48 PM
ahmadsamir created this revision.
ahmadsamir added a comment.EditedOct 12 2019, 4:50 PM

I don't use IRC much, so I don't know how to thoroughly test the SSL encryption when authenticating with a name server; if someone could point me to some docs/guide about that, or test the patch himself, that'd be great.

Edit: and of course testing connecting to a server using SSL (which seems to work with chat.freenode.net).

ahmadsamir updated this revision to Diff 67833.Oct 13 2019, 11:17 AM
ahmadsamir edited the summary of this revision. (Show Details)
ahmadsamir removed reviewers: hein, mlaurent.

Use KSslErrorUiData directly when calling askIgnoreSslErrors

ahmadsamir updated this revision to Diff 67835.Oct 13 2019, 11:25 AM
ahmadsamir retitled this revision from Port from deprecated KTcpSocket to QSslSocket to [Konversation] Port from deprecated KTcpSocket to QSslSocket.

Better commit message

dvratil accepted this revision.Oct 19 2019, 11:00 AM

Looks good to me, thanks!

This revision is now accepted and ready to land.Oct 19 2019, 11:00 AM
Closed by commit R7:458822190452: [Konversation] Port from deprecated KTcpSocket to QSslSocket (authored by ahmadsamir). · Explain WhyOct 19 2019, 9:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
Msrc/CMakeLists.txt (1 line)
Msrc/irc/server.h (8 lines)
Msrc/irc/server.cpp (54 lines)

Diff 67833

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/irc/server.h

Loading...
View Options

src/irc/server.cpp

Loading...