Differential D24588

[SslUi] Add api docs for askIgnoreSslErrors()
ClosedPublic
Actions

Authored by ahmadsamir on Oct 12 2019, 9:42 AM.

Details

Reviewers
dfaure
vkrause
Commits
R241:c38591b9d2a9: [SslUi] Add api docs for askIgnoreSslErrors()
Summary

This is needed as part of porting Koversation to use QSslSocket instead
of KTcpSocket.

Test Plan

The code compiles

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Oct 12 2019, 9:42 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 12 2019, 9:42 AM
ahmadsamir requested review of this revision.Oct 12 2019, 9:42 AM
dfaure added a comment.Oct 12 2019, 9:56 PM

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

src/widgets/sslui.h
40

Missing docu, at least @since 5.64

ahmadsamir added a comment.Oct 12 2019, 10:33 PM
In D24588#546229, @dfaure wrote:

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

My reasoning is, konversation only needs to know about SslUi::askIgnoreSslErrors and not KSslErrorUiData (implementation detail in SslUi). It's more "streamlined" for users of askIgnoreSslErrors to pass it an SSL socket rather than a KSslErrorUiData object. Anyway, I don't mind either way.

ahmadsamir updated this revision to Diff 67817.Oct 12 2019, 11:06 PM

Api docs...

ahmadsamir updated this revision to Diff 67818.Oct 12 2019, 11:09 PM

@since should actually be in the future

vkrause added a comment.Oct 13 2019, 9:09 AM
In D24588#546229, @dfaure wrote:

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

That would be my gut feeling as well, ie. have sslui depend on the abstract error representation, not on all possible error sources. OTOH it's not changing the dependency situation overall here so no strong objection to that either. In any case the KTcpSocket variant should be deprecated eventually.

ahmadsamir added a comment.Oct 13 2019, 11:07 AM
In D24588#546367, @vkrause wrote:
In D24588#546229, @dfaure wrote:

Hmm, why not just do KSslErrorUiData uiData(socket); in the caller, or even just askIgnoreSslErrors(KSslErrorUiData(socket), storedRules).
Don't know, just wondering (not objecting). @vkrause, any opinion?

That would be my gut feeling as well, ie. have sslui depend on the abstract error representation, not on all possible error sources. OTOH it's not changing the dependency situation overall here so no strong objection to that either. In any case the KTcpSocket variant should be deprecated eventually.

That makes more sense, (so I take what I said previously back... partly anyway; this way the implementation detail, i.e. the socket type, is hidden from SslUi so that it needs only a KSslErrorUiData).

ahmadsamir updated this revision to Diff 67834.Oct 13 2019, 11:24 AM
ahmadsamir retitled this revision from [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket to [SslUi] Add api docs for askIgnoreSslErrors().

Since I wrote the docs bit anyway

dfaure accepted this revision.Oct 14 2019, 7:31 AM
This revision is now accepted and ready to land.Oct 14 2019, 7:31 AM
Closed by commit R241:c38591b9d2a9: [SslUi] Add api docs for askIgnoreSslErrors() (authored by ahmadsamir). · Explain WhyOct 14 2019, 10:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/sslui.h (14 lines)

Diff 67892

View Options

src/widgets/sslui.h

Loading...