edit mode menu action
edit mode dbus property for systemsettings
containmentlayoutmanager goes out of edit mode only when the whole
plasma app loses focus, so the panel controlled doesn't make it go out
of it
Details
Details
- Reviewers
ngraham GB_2 davidedmundson - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10402: Find a way to remove the Desktop Toolbox in its current form (i.e. a hamburger menu button in the corner of the screen)
T11094: Improve discoverability of widget configuration
T10190: (Re)define modes when editing panels and widgets - Commits
- R120:c9c0f070a91b: edit mode action and dbus
iaction shows in context menu, works
property exposed on dbus works
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- mart/editMode
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17093 Build 17111: arc lint + arc unit
| components/containmentlayoutmanager/appletslayout.cpp | ||
|---|---|---|
| 100 | But we only evaluate this when this window changes - doesn't that mean we could when any other plasma window had focus and then loses it? | |
Comment Actions
I wonder if the widget resize handles should become visible all the time when in edit mode. Otherwise nothing visually changes with the widgets on the desktop, and it might not be obvious enough that you can change them.
Comment Actions
I tought about it too, tough maybe if everyhting is visible (right now the resize handles and the bigger applet handle are linked in visibility) wouldn't look very messy and cluttered?
| components/containmentlayoutmanager/appletslayout.cpp | ||
|---|---|---|
| 100 | right.. it wouldn't notice if the edit mode was initiated when its window not in focus, i-.e. dbus from systemsettings case. | |
| components/containmentlayoutmanager/appletslayout.cpp | ||
|---|---|---|
| 100 | different approach in current version | |
Comment Actions
Maybe, but this is an explicit edit mode, so it might make sense to have the editing controls more obvious?
Comment Actions
As it can be seen there, we can have situations like applets going over the handle of another one or resize handles perfectly overlapping one another, and that can't be avoied technically, it looks simply broken
(and no, i don't want to move everything inside the applet area because they can become very small, as small as a single icon, in which would make the controls unusable, at least in touch mode, so i consider the design of the handles pretty much final)
there may be added something visible that's shown which are not the handles, not sure what
Comment Actions
Just showing the handles when you hover over a widget (or tap on one on touch) is fine IMO.
Comment Actions
It still leaves the edit mode when closing a panel controller toolbox which isn't consistent with the widget explorer and it has a few side effects such as not being able to edit three panels or not being able to add widgets from the panel controller toolbox and keeping the panel controller toolbox open.