Differential D24010

Fix generating properties that start with an uppercase letter
ClosedPublic
Actions

Authored by apol on Sep 16 2019, 10:05 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Frameworks
Commits
R237:a23acd2f1535: Fix generating properties that start with an uppercase letter
Summary

We were not adjusting the property name to the getter letter-casing.

Test Plan

See added test, also fixes the issue that made me realize this issue.

Diff Detail

Repository
R237 KConfig
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16663
Build 16681: arc lint + arc unit
apol created this revision.Sep 16 2019, 10:05 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 16 2019, 10:05 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Sep 16 2019, 10:05 PM
aacid added a subscriber: aacid.Sep 16 2019, 10:12 PM

Doesn't this create any change on the other test13 files?

apol updated this revision to Diff 66271.Sep 16 2019, 10:20 PM

Also make the property lowercase

QML doesn't like properties that start uppercase

apol updated this revision to Diff 67204.Oct 2 2019, 4:32 PM

Update test, it seems like tests aren't comparing with .ref now :(

davidedmundson accepted this revision.Oct 3 2019, 9:57 PM
This revision is now accepted and ready to land.Oct 3 2019, 9:57 PM
Closed by commit R237:a23acd2f1535: Fix generating properties that start with an uppercase letter (authored by apol). · Explain WhyOct 3 2019, 11:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66271

View Options

autotests/kconfig_compiler/test13.kcfg

Loading...
View Options

src/kconfig_compiler/kconfig_compiler.cpp

Loading...