Also makes QML imports consistent.
Details
- Reviewers
ngraham mart broulik - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10862: Make QML imports consistent
- Commits
- R124:b42479962795: Port System Settings sidebar to QQC2
Also makes QML imports consistent.
Open the System Settings. Everything should still work.
Diff Detail
- Repository
- R124 System Settings
- Branch
- port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14867 Build 14885: arc lint + arc unit
Yeah that's pretty bad. I think we need to fix that first--or at the very least, make it close when clicking on the button.
It does that. Making it close when clicking anywhere would need some C++ code though.
If it would be draining to do now, we can leave that menu at QQC1 and add a note pointing to a bug report?
Ah so it does. I think that's the most important case to cover, so tentative +1 from me.
sidebar/SidebarMode.cpp | ||
---|---|---|
570 | Not a huge fan of this. |
sidebar/SidebarMode.cpp | ||
---|---|---|
570 | Not really, seems like the KQuickStyleItem only has access to the QML window of the menu control and also can't detect events on the rest of the QWidget window :( |
Use Qt Labs Platform menu (need to wait until https://bugreports.qt.io/browse/QTBUG-77404 is fixed)
Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any moment in any future release
Maybe the show most used action should go in a separate patch. This one feels like it's getting overloaded with too many different changes.
Yeah, that feature is also not ready yet, because it currently doesn't reset the sidebar selection.
sidebar/SidebarMode.cpp | ||
---|---|---|
401 | This leaks. | |
402 | const | |
403 | I think it's better to iterate the list of actions and then get them from the collection. This way the order is also preserved correctly: for (const QString &actionName : actionList) { menu->addAction(d->collection->action(actionName); } | |
409 | Don't exec() in conjunction with QML, this is just asking for trouble. Use popup() instead | |
sidebar/package/contents/ui/main.qml | ||
44 | Can you instead do a Q_PROPERTY(bool actionMenuVisible ...) in systemsettings which you set true before the menu opens and set false in aboutToHide. Then bind the checked of the button to it. |
app/SettingsBase.cpp | ||
---|---|---|
143 ↗ | (On Diff #63799) | lolwut The default shortcut for "Configure" is Ctrl+⇧+comma these days! I never even new this had a shortcut because only with your patch does it become visible. :) |