This fixes issue 398731 by restoring the "search wrapped" info message to its former type and position.
BUG: 398731
dhaumann |
KTextEditor |
This fixes issue 398731 by restoring the "search wrapped" info message to its former type and position.
BUG: 398731
works as intended (= as before #cc8b2208)
Lint Skipped |
Unit Tests Skipped |
Buildable 8978 | |
Build 8996: arc lint + arc unit |
I'm in favor of this. Ever since the message was moved to the middle of the screen, it's annoyed me by covering up the search result itself. If the bottom-right corner is considered too hidden, maybe it should be horizontally centered, and moved up 50 pixels or so from the bottom of the view? But anything's better than covering up the found matches. :)
Also +1 for using the "Information" style rather than "Positive". That seems semantically correct to me.
I quote myself from D19367 TEST PLAN Potential TODOs:
There is a status (KSqueezedTextLabel) set in indicateMatch, but I have never seen this hint. Tinker the UI file make it visible. Not so bad. Do anyone knows why this is still there? May that be better to use instead of the fancy in-view-hint which is sometimes annoying because it hides the text? ... PowerUi would need such label too.
No, do not want so say that this label is better, just for info.
@neundorf With this we are back to where we came from. Interesting to see how history repeats, and repeats, and repeats... Accepting this change means a wont-fix to your wish to move it to the center.
@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?
@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?
You don't mean the widget through which you enter the pattern to search on I hope?
@loh.tar The line edit in the search bar was once used before the floating message widgets in the view even existed. I guess it's legacy and possibly can be removed?You don't mean the widget through which you enter the pattern to search on I hope?
That quote reads a little strange. There is a label right from the line edit, now always hidden.
I had talked with Christoph and Dominik elsewhere to modify this wrap message in a way to only be shown when the start position is wrapped, but not top/bottom of the document.
That will reduce the times this message can be annoying and for my taste is a much more useful hint.