Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.

In D19005#412258, @vkrause wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

In D19005#414313, @apol wrote:

In D19005#412258, @vkrause wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

ah, that makes more sense, no idea why that seemed to break things here then though