This patch makes the dupe test only compare the actual icon directories, not everything in the target's build directory. This eliminates false positives and makes it run faster.
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- dupe-test-reliability (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6658 Build 6676: arc lint + arc unit
Comment Actions
I found an issue.
With the patch, the dupe test does not detect 2 identical files with the same name in different categories. It is able to detect 2 identical files with different names.
How to reproduce:
- cp icons/categories/32/applications-internet.svg icons/preferences/32/applications-internet.svg
- make && make test
Failed test before patch (includes false positives and true positive):
Passed test after patch (no false positives or true positive):
Comment Actions
Since this is essentially a workaround for doing in-source builds, the obvious superior course of action is for me to the the work to set up some basic infrastructure for painless out-of-source builds. :)