Right now, the "Create New" menu's functionality is not visible with Dolphin's default layout that has a Control button instead of a menubar. This patch adds that functionality to the Control button's menu so that it's actually discoverable for regular users.
Details
Details
- Reviewers
broulik elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:7f223f93df5b: Add "Create New" menu to "Control" button
All menu items work.
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- create-new-menu-in-control-button (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 3017 Build 3035: arc lint + arc unit
Comment Actions
Btw we broke the "Create New" button on read-only folders. Time to write an unit test for that...
src/dolphinmainwindow.cpp | ||
---|---|---|
923 | Why here though? "Create New" belongs to the File menu, so it should probably be the very first thing in the Control menu. |
Comment Actions
My thinking was that it's sort of a tool so it could go next to the tools menu, but I can move it higher up.
src/dolphinmainwindow.cpp | ||
---|---|---|
867 | Why this? |
Comment Actions
I like the idea, it makes it more easily discoverable if you're using touch. Not that I'm advocating cluttering this menu with a million things, but something to think about are the other functions in the right-click menu. Just thinking out loud.
src/dolphinmainwindow.cpp | ||
---|---|---|
863–870 | Why duplicate the menu initialization? It's enough to use this one-liner: menu->addMenu(m_newFileMenu->menu()); |