Java: add binaries & hex-float, and support underscores in numbers
ClosedPublic

Authored by nibags on Aug 9 2018, 9:01 AM.

Details

Summary

Some improvements in the highlighting of literal numbers:

  • Add binaries: 0b1010 [1][3].

BUG: 386391

  • Allow underscores in numbers (Float, Int, Hex, Octal & Binary) [2][3][4].
NOTE: The exact format of the numbers supported can be found in ref. [3] & [4].
  • Add hexadecimal floating point: 0xA21.F18p+123 [4].
  • Add missing suffixes in numbers: "L" in Hex & Octal, and "D" in Float [3][4].

References:

Diff Detail

Repository
R216 Syntax Highlighting
Branch
java-improve-numbers
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1633
Build 1651: arc lint + arc unit
nibags created this revision.Aug 9 2018, 9:01 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 9 2018, 9:01 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Aug 9 2018, 9:01 AM
  • BUG 386391

This needs to be on its own line (not as part of a bulleted list) and there needs to be a colon. Like this:

BUG: 386391

nibags edited the summary of this revision. (Show Details)Aug 10 2018, 5:20 PM
cullmann accepted this revision.Aug 12 2018, 2:35 PM

Looks reasonable.

This revision is now accepted and ready to land.Aug 12 2018, 2:35 PM
nibags closed this revision.Aug 13 2018, 2:39 AM