- Do not add open files to m_openFiles
- Reload openfiles instead of opening a new copy
- Do not start with "new File" . User can't save it and can not print it unless saved
- Allow for closing of files in the gcode editor
- track the tab / documents to keep view current (needs more work ?)
Details
Open Documents, Close documents.
Try to open the same document hopefully get pushed to its tab..
Diff Detail
- Repository
- R231 Atelier
- Branch
- loadone
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/widgets/gcodeeditorwidget.cpp | ||
---|---|---|
48 | This will bring the file with same URL to the front ? |
src/widgets/gcodeeditorwidget.cpp | ||
---|---|---|
48 | It only reloads the document, (save prompt shown if file has changed in the editor ) This does not change the tab. I will lookin to adding that as I think its expected behavior. |
- C++11 for
- Mapping to better track open files.
- Remove creation of "New File". (this will confuse user can't save until you open a file in our set
up and cant print unless written to disk. We can redo this later in a better way when those are
solved)
- GCodeEditor::fileClosed emited when a file is closed in the view. This is then removed from the
- Close the files delete the document
- Merge branch 'loadone' into LOADCLOSE
- Reload openfiles instead of opening a new copy
- Add file close. Works well under most cases
src/mainwindow.cpp | ||
---|---|---|
194 | you can remove the first this. |
You will be pushed to the tab on open. This needs some more testing from us all. I have found abug in this that im not quite sure I see whats wrong yet.
Open three files close the second one the view for item 1 or 3 may be empty. Maybe @cullmann or @tcanabrava can help with that ?
- Clean up reload.
- Use QMAP[Key] = value; to put items in the map
- Try to see why if a bunch of files are open sometimes when closing one a view is then empty (first or last)
src/widgets/gcodeeditorwidget.h | ||
---|---|---|
51 | QUrl& |