Details
Details
- Reviewers
laysrodrigues tcanabrava patrickelectric
Sometimes it does close right and it crashes when you open a new file or close one? it happened once in my testing..
Sometimes if more then one files is open they all close ?
@cullmann can you see if im closing the files correctly .
Diff Detail
Diff Detail
- Repository
- R231 Atelier
- Branch
- closeFiles
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/mainwindow.cpp | ||
---|---|---|
173 | File as reference. |
Comment Actions
Hmm, of example in the
connect(gcodeEditor, &GCodeEditorWidget::updateClientFactory, this, [this](KTextEditor::View* view){
guiFactory()->removeClient(m_currEditorView); guiFactory()->addClient(view); m_currEditorView = view; });
part: could m_currEditorView be there null at the start or later? must one guard that?
Comment Actions
Beside that, I am not sure how you handle view deletes, isn't the current view pointer then dangling?
Comment Actions
I think this is the reason for the crash on close if more then two files are opened..
src/mainwindow.cpp | ||
---|---|---|
161–171 | && view |