[API dox] New UI marker @item:valuesuffix
ClosedPublic

Authored by kossebau on Apr 19 2018, 2:43 PM.

Details

Summary

Allows to mark strings which are used for concatenating them directly to a
value string, to result in some quantity string.

As e.g. useful with Qt's QSpinBox and QCC1 SpinBox, which have a suffix
string property which then is displayed concatenated to the currently
selected value.

Diff Detail

Repository
R249 KI18n
Branch
additemvaluesuffixuimaker
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Apr 19 2018, 2:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 19 2018, 2:43 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kossebau requested review of this revision.Apr 19 2018, 2:43 PM
ilic accepted this revision.Apr 19 2018, 2:55 PM
This revision is now accepted and ready to land.Apr 19 2018, 2:55 PM

@ilic Thanks for the quick review :)

Will keep this review request open until Sun. April 29th, to give translators more chance to tell any issue they might see.

aacid added a subscriber: aacid.Apr 19 2018, 7:31 PM

All the other elements of that list have an entry like

./src/kuitmarkup.cpp:281: SET_CUE(InrangeCue, QStringLiteral("inrange"));

Do we need that too for valuesuffix?

All the other elements of that list have an entry like

./src/kuitmarkup.cpp:281: SET_CUE(InrangeCue, QStringLiteral("inrange"));

Do we need that too for valuesuffix?

Good find, did not know there is a complete data model in code for them here. At least for consistency I would expect we should add this here as well, will update patches.

kossebau updated this revision to Diff 32605.Apr 19 2018, 8:07 PM

add also in kuit handling code

This revision was automatically updated to reflect the committed changes.