[API dox] New UI marker @info:placeholder
ClosedPublic
Actions

Authored by kossebau on Apr 19 2018, 3:00 PM.

Details

Reviewers

ilic

Group Reviewers

Localization

Commits

R249:449e6fd556ee: [API dox] New UI marker @info:placeholder

Summary

Allows to mark strings which are used as placeholder text.

As e.g. useful with Qt's QLineEdit where one can set a placeholderText
property.

Repository

R249 KI18n

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

kossebau requested review of this revision.Apr 19 2018, 3:00 PM

add also in kuit handling code

Would push then on Sun. April 29th, if no-one has objections or comments. Cmp. also D12353

Also created task T8589 for the KDE HIG to provide some guidelines for placeholder text usage & styling

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2018, 6:58 PM

This revision was automatically updated to reflect the committed changes.

The diff is a bit weird, as if it is for the vallusuffix from D12353. But looks good in the repository as committed.

In D12355#255342, @ilic wrote:

The diff is a bit weird, as if it is for the vallusuffix from D12353. But looks good in the repository as committed.

...or, my browser did something wrong. Or PEBKAC.

Phabricator display of diff looks fine here, both in firefox (logged in) & chromium (not logged in). Can you specify "a bit weird"? :)

			Path	Packages
M			docs/programmers-guide.md (3 lines)
M			src/kuitmarkup.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32572	9c32bda		Apr 19 2018, 3:00 PM	★	★
Diff 2	32604	9c32bda	add also in kuit handling code	Apr 19 2018, 8:03 PM	★	★
Diff 3	33262	b88bb7e	R249:449e6fd556ee40f71cfaaaeb1bf311fc5e3ac446	Apr 28 2018, 6:57 PM	★	★