Differential D10532

[Information Panel] Adjust painting icons for high dpi scaling
ClosedPublic
Actions

Authored by broulik on Feb 15 2018, 10:10 AM.

Details

Reviewers
elvisangelaccio
apol
Group Reviewers
Dolphin
Commits
R318:ae67f991951e: [Information Panel] Adjust painting icons for high dpi scaling
Summary

Instead of creating our own KIconLoader (which takes ~5ms here) just use QIcon::fromTheme which already does everything right.

BUG: 390488

Test Plan

Multi-selection before


Multi-selection after

Search before


Search after

Before


After

Overlays are also correctly painted with D9814

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik requested review of this revision.Feb 15 2018, 10:10 AM
broulik created this revision.
apol accepted this revision.Feb 15 2018, 12:26 PM
apol added a subscriber: apol.

Although it should probably have a ::setIcon rather than a ::setPixmap(hugePixmap)

This revision is now accepted and ready to land.Feb 15 2018, 12:26 PM
Closed by commit R318:ae67f991951e: [Information Panel] Adjust painting icons for high dpi scaling (authored by broulik). · Explain WhyFeb 15 2018, 12:37 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Feb 18 2018, 5:53 PM

So, what's wrong with KIconLoader? Shouldn't we fix it?

broulik added a comment.Feb 19 2018, 11:35 AM

Shouldn't we fix it?

Sure. I started working on that in D6313 but it's quite complex to get right. I need to add tons of overloads taking a "scale" argument while keeping API compatibility, etc.

Revision Contents
Changeset List

Diff 27220

View Options

src/panels/information/informationpanelcontent.cpp

Loading...