Keeps them from being painted outside view and scales them with the image they're supposed to be painted on.
Details
Details
- Reviewers
davidedmundson apol - Group Reviewers
Frameworks - Commits
- R302:0b59d17d5949: [KIconLoader] Take into account devicePixelRatio for overlays
Originally posted as https://git.reviewboard.kde.org/r/129083/
The network share overlay issue I mentioned in https://git.reviewboard.kde.org/r/129084/ is moot as it's just KFileItem using a wrong (as in non emblem) icon for that
@emmanuelp suggested changing int to real and use QPointF but you cannot have half pixels, so I didn't update the patch
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kiconloader.cpp | ||
|---|---|---|
| 542 | Typically it's a lot easier to do everything in logical co-ordinates, rather than effectively convert co-ordinates to device pixels and then convert back. Especially if you ever mix up paint devices with different ratios. But in this case it works...so ship it. | |