| dfaure |
| Frameworks |
Puts in place a plugin system that exposes API to extract information to
send the handler. This allows us to de-couple from different modules that
need to be sequentially instanciated at the moment (and ifdef'd).
An interesting advantage we could get after adopting this is that we could have more framework-specific handlers available.
Crashed kate, still get the right drkonqi.
| No Linters Available |
| No Unit Test Coverage |
I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help?
| src/plugins/kstartupinfoplugin.cpp | ||
|---|---|---|
| 27 | is the \ intended? | |
Ah, you are right, I forgot to mention it. I thought about this process as a 2-step, where the second step would be moving these handlers to frameworksintegration.
| src/kcrash.cpp | ||
|---|---|---|
| 436–437 | You have a comment to follow :) | |
Hmm, I don't like that. That turns frameworksintegration into the everything and the kitchen sink. Why should one depend on KIO to get a working KCrash?
In the end that results in worse dependencies than before.
| src/kcrash.cpp | ||
|---|---|---|
| 436–437 | You can't use QVector here. We're crashing, likely due to corrupted memory, the whole point of this code is to NOT do any memory allocation. You should revert to const char*[], or use something that always allocates on the stack (e.g. QVarLengthArray, if preallocated to be big enough). | |
Dropped usage of QMap and QVector from the handler
Still using QPluginLoader and QDirIterator which probably are as bad as those.
| src/config-kcrash.h.cmake | ||
|---|---|---|
| 7 | CMAKE_INSTALL_FULL_PLUGINDIR/kcrashhandlers | |
That is a very big problem. QDirIterator could be ported to lower-level APIs, but plugin loading means memory allocations.
You might want to look into starting a helper binary that is part of the kcrash frameworks, rather than loading a plugin directly.
| src/kcrash.cpp | ||
|---|---|---|
| 436–437 | Yes... that makes sense. But then possibly worse than that is the use of QMap. Will rethink the approach. | |
Please disregard the last message, I didn't mean to send that, I wrote it some days ago.