letter_in_word: Fixing overriding issues with images when expanded
Closed, ResolvedPublic

Description

When an element is selected and it expands, the image of the element is overriding the element in upper row

jjazeix renamed this task from Fixing overriding issues with images when expanded to letter_in_word: Fixing overriding issues with images when expanded.Apr 23 2017, 4:45 PM
souradeepbarua removed souradeepbarua as the assignee of this task.Aug 10 2017, 2:44 AM
amankumargupta removed amankumargupta as the assignee of this task.Dec 27 2017, 6:28 PM
amankumargupta moved this task from WIP to Backlog on the GCompris: Improvements board.
amankumargupta added a subscriber: amankumargupta.

can i work on this issue?

You should only work on 1 task at a time. As you were interested in https://phabricator.kde.org/T7610, I assigned it to you. Once you have finished it, you can assign a new one to yourself (this one or another) but it would be better to not have too much tasks assigned at same time

@jjazeix , can i take this now as the earlier one is now under review process ?

yes, sure, I'll take a look at the other one when I have time

For this activity if we increase the distance between 2 row, will it be good ?

The last time I tried increasing distance between rows, I remember elements get overridden by the bar and OK button which is not good.

I created a PR : https://github.com/gcompris/GCompris-qt/pull/215
Please suggest if any other changes are required.

As said by Aman: https://pasteboard.co/H64MuWL.png
This activity needs more work to better place the elements (like for colors activity).

Can we implement a scroll bar or highlight the selected object with another colour or tick mark instead of scaling it ?

For sure, not a scrollbar, there is enough space to have all in the screen. Ticking could be a solution

@jjazeix , As I suggested for a tick , I made some changes . Here is a screenshot of how it looks with this solution : https://pasteboard.co/H7lUxpn.png
the image of tick and position can be changes if this looks good . Please suggest...

I agree ticking can work. I also think I need to update the whole layout of this activity at some point, but this little change is a good solution for now.

You can do this change, and I'll make a new icon for the tick soon.

@timotheegiet , so should I make the commit with the icon that is in the screenshot.

Oh, actually no need to add an icon in your commit, you can use "qrc:/gcompris/src/core/resource/apply.svg" ;)

@timotheegiet , I made the PR with the mentioned changes. Please have a look at : https://github.com/gcompris/GCompris-qt/pull/219

jjazeix closed this task as Resolved.Mar 3 2018, 1:39 PM
jjazeix moved this task from Backlog to Done on the GCompris: Improvements board.
jjazeix claimed this task.

Commited in https://commits.kde.org/gcompris/764ea37928a2ecc564575195b200caa2b1f2504a with small changes.

Thank you,

Johnny