Control the hose pipe: Fix layout for vertical mode
Closed, ResolvedPublic

Description

Fix a visual issue of this activity in vertical mode.
The pipe should always end right above the fire, and not go out of the screen.
https://pasteboard.co/GLwWVCB.png

asagtani created this task.Dec 16 2017, 3:04 PM

i'd like to work on this issue.

@parthpartani hi, sure you can start working on it. Don't hesitate to ask in case of any doubt via IRC, mail or here.

@asagtani , i have made some changes and build it. It works fine and as you mentioned (ends above the fire) . Should i check it for android also?

jjazeix added a subscriber: jjazeix.

Hi,

I assigned the task to you as you started to work on it.

There are instructions to help you compile for android at http://gcompris.net/wiki/Qt_Quick_development_process#Compiling_GCompris_for_Android
There might be some issues (some changes with latest sdk/ndk) so don't hesitate to ask if you don't manage to compile.
Regarding the patch, you can provide a differential in phabricator and attach it to this task using "Edit Related Tasks" on the right menu.

Thank you

@jjazeix i 'm familiar with git but i am new to this. How do i commit changes ?

@parthpartani hi, for submitting changes you can submit your diff at https://phabricator.kde.org/differential/diff/create/ or,
create a PR on GitHub... follow steps given on http://gcompris.net/wiki/An_exercise_for_new_contributors. You can ask in case of doubt in any step.

hi , i made the PR with the changes. Here is the link : https://github.com/gcompris/GCompris-qt/pull/210

@asagtani hi , i made the changes on github but do i need to do something here too (like mockups or something in differential )

@parthpartani, hi, it's good on your side, we just need some time to review it as there are a lot of reviews to do currently and we are slower to review/accept them than the incoming number :).
I'll try to take a look today

amankumargupta closed this task as Resolved.Feb 14 2018, 7:36 AM
amankumargupta moved this task from Junior Jobs to Done on the GCompris: Improvements board.
amankumargupta added a subscriber: amankumargupta.