Create Task
Maniphest T13083

Dolphin: improvements to directory size counting
Open, Needs TriagePublic
Actions

Description

After D25335 has landed, we can envision several improvements

  • Have a singleton thread and worker, so that no matter how many tabs and split views dolphin would have as much 1 worker making the disk spin.
  • prioritize folders not yet in cache to be scanned first D29562
  • prevent duplicate in queue D29562
  • share the cache / implementation with the rest of dolphin (status bar text), this would possibly need some heavy refactoring
  • share the cache / implementation with the FileMetadataWidget so it can show the same data, this would possibly need some heavy refactoring

Question to ourselves:

  • At some point, we might want to turn on by default the feature.

CC @ngraham @elvisangelaccio

Details

Differential Revisions
D29562: KDirectoryContentsCounter: Avoid scanning twice the same dir, prioritise path not in cache

Related Objects

meven created this task.May 4 2020, 5:30 AM
felixernst added a subscriber: felixernst.May 5 2020, 8:53 AM

Would it make sense for this to share a directory size counting algorithm with Filelight?

meven added a comment.May 5 2020, 9:47 AM
In T13083#229258, @felixernst wrote:

Would it make sense for this to share a directory size counting algorithm with Filelight?

This could have sayed the same about DirectorySizeJob (if not already can't remember).

The directory size counting algorithm is the easy part, and rather small, not much to gain from sharing this code.
Furthermore we have tight integration within Dolphin, starting and stopping size counting as the user moves within directories, using a cache (and soon sharing it), having a hidden files option, progressive results...

felixernst added a comment.May 5 2020, 11:46 AM

Alright. Seems like at best Filelight could make use of Dolphin's calculated sizes and even that is probably not worth the trouble. I was just thinking that Filelight was quite fast to calculate the recursive sizes of all folders on my SSD and if Dolphin just had this data this task would be done but that was apparently too naive a thought.

meven updated the task description. (Show Details)May 9 2020, 4:45 PM