maxrd2 (Mladen Milinkovic)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2017, 11:57 PM (135 w, 3 d)
Availability
Available

Recent Activity

Yesterday

maxrd2 updated the diff for D28600: libs/qtav: fixed package installation.

Reverted QML install path back to PREFIX/qml

Mon, Apr 6, 6:44 PM
maxrd2 added inline comments to D28600: libs/qtav: fixed package installation.
Mon, Apr 6, 6:42 PM
maxrd2 updated the summary of D28600: libs/qtav: fixed package installation.
Mon, Apr 6, 2:50 PM
maxrd2 updated the diff for D28600: libs/qtav: fixed package installation.
  • libs/qtav: moved to cmake build
Mon, Apr 6, 2:45 PM
maxrd2 added a comment to D28600: libs/qtav: fixed package installation.

As it looks like the install script sucks... and I expect it to just copy the binaries and some headers...
Can we just do it with our functions?

Mon, Apr 6, 12:55 PM

Sun, Apr 5

maxrd2 requested review of D28600: libs/qtav: fixed package installation.
Sun, Apr 5, 6:27 PM

Sat, Apr 4

maxrd2 added a comment to D28545: libs/lapack: fixed windows mingw build.

Well if the patch works...
Else pls motivate the maintainers if mingw to provide a new binary release.

Sat, Apr 4, 11:30 PM
maxrd2 committed R877:dd923cc21b7d: libs/ffmpeg: fixed *.lib installation to bin/ (authored by maxrd2).
libs/ffmpeg: fixed *.lib installation to bin/
Sat, Apr 4, 10:15 PM
maxrd2 closed D28543: libs/ffmpeg: fixed *.lib installation to bin/.
Sat, Apr 4, 10:15 PM
maxrd2 added a comment to D28545: libs/lapack: fixed windows mingw build.

I’d the fortran part used at all? Can we just disable it?

Sat, Apr 4, 10:00 PM
maxrd2 updated the diff for D28545: libs/lapack: fixed windows mingw build.

Removed useless dependency to dev-utils/mingw-w64 on lapack

Sat, Apr 4, 9:16 PM
maxrd2 updated the diff for D28545: libs/lapack: fixed windows mingw build.

Changed liblapack on windows builds to produce only static library (because libgfortran 8.1 in mingw provides only static lib and dll linking fails)
Fixed pocketsphinx/sphinxbase build to work against both static and dynamic liblapack and co.
Tested on windows mingw and linux.

Sat, Apr 4, 9:13 PM
maxrd2 added a comment to D28543: libs/ffmpeg: fixed *.lib installation to bin/.

Hm maybe put it into an if msvc?

Sat, Apr 4, 8:21 PM
maxrd2 updated the diff for D28543: libs/ffmpeg: fixed *.lib installation to bin/.

Added isWin check

Sat, Apr 4, 8:18 PM
maxrd2 committed R877:52007295b9f8: libs/qtav: fixed windows build (authored by maxrd2).
libs/qtav: fixed windows build
Sat, Apr 4, 8:12 PM
maxrd2 closed D28536: libs/qtav: fixed windows build.
Sat, Apr 4, 8:12 PM
maxrd2 updated the diff for D28536: libs/qtav: fixed windows build.
  • libs/qtav: fixed windows install
Sat, Apr 4, 11:39 AM

Fri, Apr 3

maxrd2 updated the diff for D28536: libs/qtav: fixed windows build.

Moved include/lib search paths to qmake config patch

Fri, Apr 3, 8:01 PM
maxrd2 added inline comments to D28545: libs/lapack: fixed windows mingw build.
Fri, Apr 3, 7:18 PM
maxrd2 requested review of D28545: libs/lapack: fixed windows mingw build.
Fri, Apr 3, 7:12 PM
maxrd2 updated the diff for D28536: libs/qtav: fixed windows build.

Removed bin/ lib path on windows

Fri, Apr 3, 5:25 PM
maxrd2 added a dependency for D28536: libs/qtav: fixed windows build: D28543: libs/ffmpeg: fixed *.lib installation to bin/.
Fri, Apr 3, 5:22 PM
maxrd2 added a dependent revision for D28543: libs/ffmpeg: fixed *.lib installation to bin/: D28536: libs/qtav: fixed windows build.
Fri, Apr 3, 5:22 PM
maxrd2 added a comment to D28536: libs/qtav: fixed windows build.

Hm yes sounds like we should fix our ffmpeg blueprint with a post install step.

Created patch here: https://phabricator.kde.org/D28543

Fri, Apr 3, 5:21 PM
maxrd2 requested review of D28543: libs/ffmpeg: fixed *.lib installation to bin/.
Fri, Apr 3, 5:17 PM
maxrd2 updated the diff for D28536: libs/qtav: fixed windows build.

libs/qtav: fixed build

Fri, Apr 3, 1:37 PM
maxrd2 added inline comments to D28536: libs/qtav: fixed windows build.
Fri, Apr 3, 1:26 PM
maxrd2 closed D28533: Updated openssl to 1.1.1f.
Fri, Apr 3, 1:24 PM
maxrd2 committed R877:9b13986dcc28: Updated openssl to 1.1.1f (authored by maxrd2).
Updated openssl to 1.1.1f
Fri, Apr 3, 1:24 PM
maxrd2 requested review of D28536: libs/qtav: fixed windows build.
Fri, Apr 3, 1:20 PM
maxrd2 updated the diff for D28533: Updated openssl to 1.1.1f.
  • openssl: fixed installation to lib64
Fri, Apr 3, 11:26 AM
maxrd2 updated the diff for D28533: Updated openssl to 1.1.1f.
  • openssl: fixed lib/lib64 handling
Fri, Apr 3, 11:11 AM
maxrd2 added a comment to D28533: Updated openssl to 1.1.1f.

Is the dynamic lib also in the lib64 folder?
If so we should find out how to disable that....

Fri, Apr 3, 11:05 AM
maxrd2 updated the diff for D28533: Updated openssl to 1.1.1f.
  • openssl: fixed lib/lib64 handling
Fri, Apr 3, 9:37 AM
maxrd2 requested review of D28533: Updated openssl to 1.1.1f.
Fri, Apr 3, 9:23 AM

Tue, Mar 31

maxrd2 committed R877:1cb070313158: extragear/subtitlecomposer: added recipe (authored by maxrd2).
extragear/subtitlecomposer: added recipe
Tue, Mar 31, 10:42 AM
maxrd2 closed D25689: extragear/subtitlecomposer: added recipe.
Tue, Mar 31, 10:42 AM

Mon, Mar 23

maxrd2 committed R877:388078c7d5a8: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe (authored by maxrd2).
libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe
Mon, Mar 23, 12:32 PM
maxrd2 closed D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Mon, Mar 23, 12:32 PM

Wed, Mar 18

maxrd2 added inline comments to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Wed, Mar 18, 6:24 PM
maxrd2 updated the diff for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

Changed streams to use text mode

Wed, Mar 18, 6:13 PM
maxrd2 updated the diff for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Wed, Mar 18, 6:10 PM

Wed, Mar 11

maxrd2 added a comment to D25689: extragear/subtitlecomposer: added recipe.

@vonreth I'm done doing the changes here. Would appreciate if you can review this when you have time.

Wed, Mar 11, 9:04 PM
maxrd2 added a dependent revision for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe: D25689: extragear/subtitlecomposer: added recipe.
Wed, Mar 11, 3:02 PM
maxrd2 added a dependency for D25689: extragear/subtitlecomposer: added recipe: D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Wed, Mar 11, 3:02 PM
maxrd2 updated the summary of D25689: extragear/subtitlecomposer: added recipe.
Wed, Mar 11, 3:01 PM
maxrd2 updated the diff for D25689: extragear/subtitlecomposer: added recipe.

Cleaned up build script. Added correct dependencies.

Wed, Mar 11, 3:01 PM

Tue, Mar 10

maxrd2 added inline comments to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Tue, Mar 10, 7:29 PM
maxrd2 updated the diff for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

replaced sed command with python regexp code

Tue, Mar 10, 7:27 PM
maxrd2 added inline comments to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Tue, Mar 10, 4:33 PM
maxrd2 updated the diff for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

libs/sphinxbase: switched to tarball, included autogen.sh
libs/pocketsphinx: switched to tarball, included autogen.sh

Tue, Mar 10, 4:23 PM
maxrd2 added a comment to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

In general we should try to use tarballs instead of unstable branches

Tue, Mar 10, 4:11 PM
maxrd2 updated the diff for D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

libs/lapack: added patch origin

Tue, Mar 10, 3:41 PM
maxrd2 added inline comments to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Tue, Mar 10, 3:39 PM
maxrd2 added a comment to D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.

libs/lapack requires gfortran compiler, am not sure whether additional steps are required or if it's there by default.

Tue, Mar 10, 3:23 PM
maxrd2 requested review of D27970: libs/lapack, libs/sphinxbase, libs/pocketsphinx: recipe.
Tue, Mar 10, 3:21 PM

Mon, Mar 9

maxrd2 added a comment to D27920: libs/qtav: added 1.13.0 recipe.

Have just noticed that there is qt-libs dir. Should I create another patch and move this from libs/qtav to qt-libs/qtav?

Mon, Mar 9, 11:13 PM
maxrd2 committed R877:03c6e294172e: libs/qtav: added 1.13.0 recipe (authored by maxrd2).
libs/qtav: added 1.13.0 recipe
Mon, Mar 9, 10:44 AM
maxrd2 closed D27920: libs/qtav: added 1.13.0 recipe.
Mon, Mar 9, 10:44 AM

Mar 7 2020

maxrd2 requested review of D27920: libs/qtav: added 1.13.0 recipe.
Mar 7 2020, 9:38 PM

Dec 7 2019

maxrd2 updated the diff for D25799: Added check that icu-config exists before patching.

Removed duplicate code (postInstall method)

Dec 7 2019, 1:37 AM
maxrd2 updated subscribers of D25799: Added check that icu-config exists before patching.
Dec 7 2019, 1:20 AM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

Have added check that file exists in https://phabricator.kde.org/D25799
It still works on linux... don't know how/where to test on windows

Dec 7 2019, 1:17 AM
maxrd2 added reviewers for D25799: Added check that icu-config exists before patching: vonreth, Craft.
Dec 7 2019, 1:16 AM
maxrd2 requested review of D25799: Added check that icu-config exists before patching.
Dec 7 2019, 1:16 AM

Dec 6 2019

maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

I don't have permissions to land it

Dec 6 2019, 5:53 PM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

ok then... thanks for the info.
Have updated the diff.

Dec 6 2019, 3:26 PM
maxrd2 updated the diff for D25687: libs/icu: fixed hardcoded path in icu-config.

Replaced $KDEROOT with CraftCore.standardDirs.craftRoot()

Dec 6 2019, 3:23 PM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

Isn't prebuilt binary package downloaded from KDE cache?
In that case will it have hardcoded craft path from those build machines?

Dec 6 2019, 3:01 PM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

@vonreth I can't replace second parameter $KDEROOT with CraftCore.standardDirs.craftRoot() as that will just hardcode different path.
Should I replace $KDEROOT with $(realpath "$(dirname "$0")/..") if KDEROOT is not good?

Dec 6 2019, 1:35 PM
maxrd2 updated the diff for D25687: libs/icu: fixed hardcoded path in icu-config.

Using os.path.join and buildprefix instead of env var.

Dec 6 2019, 1:24 PM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

@vonreth added summary.. hope this describes the issue better.

Dec 6 2019, 10:42 AM
maxrd2 updated the summary of D25687: libs/icu: fixed hardcoded path in icu-config.
Dec 6 2019, 10:40 AM
maxrd2 added a comment to D25776: Fixed system lib paths getting hardcoded.

@vonreth I believe I don't have permissions to land this patch.

Dec 6 2019, 10:35 AM

Dec 5 2019

maxrd2 updated the diff for D25776: Fixed system lib paths getting hardcoded.

oops

Dec 5 2019, 11:15 PM
maxrd2 updated the summary of D25776: Fixed system lib paths getting hardcoded.
Dec 5 2019, 11:08 PM
maxrd2 requested review of D25776: Fixed system lib paths getting hardcoded.
Dec 5 2019, 11:07 PM

Dec 2 2019

maxrd2 requested review of D25689: extragear/subtitlecomposer: added recipe.
Dec 2 2019, 6:05 PM
maxrd2 added a reviewer for D25687: libs/icu: fixed hardcoded path in icu-config: vonreth.
Dec 2 2019, 5:44 PM
maxrd2 added a reviewer for D25687: libs/icu: fixed hardcoded path in icu-config: Craft.
Dec 2 2019, 5:42 PM
maxrd2 updated the diff for D25687: libs/icu: fixed hardcoded path in icu-config.

corrected return value

Dec 2 2019, 5:35 PM
maxrd2 added a comment to D25687: libs/icu: fixed hardcoded path in icu-config.

bin/icu-config had prefix variable hardcoded like this:

default_prefix="/home/appimage/Craft/BinaryCache/linux-64-gcc"
Dec 2 2019, 5:33 PM
maxrd2 requested review of D25687: libs/icu: fixed hardcoded path in icu-config.
Dec 2 2019, 5:30 PM

Nov 30 2019

maxrd2 committed R499:4f5dc7866247: Added Subtitle Composer (authored by maxrd2).
Added Subtitle Composer
Nov 30 2019, 6:58 PM
maxrd2 closed D25625: Added Subtitle Composer.
Nov 30 2019, 6:58 PM
maxrd2 added a comment to D25625: Added Subtitle Composer.

External dependencies like gstreamer, libmpv, pocketsphinx are handled elsewhere.. right?

Nov 30 2019, 6:49 PM
maxrd2 updated the diff for D25625: Added Subtitle Composer.

Removed dependency-data changes

Nov 30 2019, 6:48 PM
maxrd2 added reviewers for D25625: Added Subtitle Composer: bcooksley, ngraham.
Nov 30 2019, 11:50 AM
maxrd2 requested review of D25625: Added Subtitle Composer.
Nov 30 2019, 11:42 AM

Nov 23 2019

maxrd2 committed R234:b4a7b13d1d9c: Add screenshot for Subtitle Composer (authored by maxrd2).
Add screenshot for Subtitle Composer
Nov 23 2019, 12:01 PM

Jul 17 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Events from the window system seem to be handled after normal events.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
Is there a way to send the event so qt processes it as window system event? Have tried looking through code and documentation, but everything that deals with window system events is private.

Jul 17 2018, 2:22 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

@dfaure great.. thanks

Jul 17 2018, 2:03 PM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Rebased to master

Jul 17 2018, 1:57 PM · Frameworks

Jul 16 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

@ngraham Don't think I can. I have no commit rights.
Should i revert/remove test part, as currently it doesn't test anything i believe.. it always passes.

Jul 16 2018, 8:19 PM · Frameworks

Jul 5 2018

maxrd2 added inline comments to D13808: Fix KMainWindow saving incorrect widget settings.
Jul 5 2018, 9:51 PM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Clened up test code. Replaced isVisible() with isHidden() test to match KMainWindow's condition.

Jul 5 2018, 9:38 PM · Frameworks
maxrd2 added inline comments to D13808: Fix KMainWindow saving incorrect widget settings.
Jul 5 2018, 3:51 PM · Frameworks

Jul 4 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277
Seems it's not their bug. And Qt guy commented there with:

... You should, however, not save the window layout anymore then, because after closeEvent() any other widgets or child windows could also be gone already...

Jul 4 2018, 4:48 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Thank you! QEventLoop and creating window with new operator did it. Now the only problem is that no matter how i close the window from code it's not reproducing behavior. Only closing the window manually through window manager works.
Have tried:
QApplication::postEvent(mw, new QCloseEvent); // this one does absolutely nothing
QApplication::postEvent(mw, new QDeferredDeleteEvent);
QTimer::singleShot(1000, [&](){ QApplication::sendEvent(mw, new QDeferredDeleteEvent); });
mv.close();
QTimer::singleShot(1000, [&](){ mv.close(); });

Jul 4 2018, 4:56 AM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Added event loop to test and replicated wanted KMainWindow behavior.

Jul 4 2018, 4:56 AM · Frameworks