maxrd2 (Mladen Milinkovic)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 1 2017, 11:57 PM (67 w, 3 d)
Availability
Available

Recent Activity

Jul 17 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Events from the window system seem to be handled after normal events.
http://code.qt.io/cgit/qt/qtbase.git/tree/src/platformsupport/eventdispatchers/qeventdispatcher_glib.cpp#n70
Is there a way to send the event so qt processes it as window system event? Have tried looking through code and documentation, but everything that deals with window system events is private.

Jul 17 2018, 2:22 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

@dfaure great.. thanks

Jul 17 2018, 2:03 PM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Rebased to master

Jul 17 2018, 1:57 PM · Frameworks

Jul 16 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

@ngraham Don't think I can. I have no commit rights.
Should i revert/remove test part, as currently it doesn't test anything i believe.. it always passes.

Jul 16 2018, 8:19 PM · Frameworks

Jul 5 2018

maxrd2 added inline comments to D13808: Fix KMainWindow saving incorrect widget settings.
Jul 5 2018, 9:51 PM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Clened up test code. Replaced isVisible() with isHidden() test to match KMainWindow's condition.

Jul 5 2018, 9:38 PM · Frameworks
maxrd2 added inline comments to D13808: Fix KMainWindow saving incorrect widget settings.
Jul 5 2018, 3:51 PM · Frameworks

Jul 4 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277
Seems it's not their bug. And Qt guy commented there with:

... You should, however, not save the window layout anymore then, because after closeEvent() any other widgets or child windows could also be gone already...

Jul 4 2018, 4:48 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Thank you! QEventLoop and creating window with new operator did it. Now the only problem is that no matter how i close the window from code it's not reproducing behavior. Only closing the window manually through window manager works.
Have tried:
QApplication::postEvent(mw, new QCloseEvent); // this one does absolutely nothing
QApplication::postEvent(mw, new QDeferredDeleteEvent);
QTimer::singleShot(1000, [&](){ QApplication::sendEvent(mw, new QDeferredDeleteEvent); });
mv.close();
QTimer::singleShot(1000, [&](){ mv.close(); });

Jul 4 2018, 4:56 AM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Added event loop to test and replicated wanted KMainWindow behavior.

Jul 4 2018, 4:56 AM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Have tried doing QApplication::processEvents() and QApplication::sendPostedEvents(), between main window instances... didnt change
Have removed mw.close() and clicked close buttons manually... didnt change
Then have started all three in separate process using QProcess and hack to main, and just now have figured that mw is supposed to be deleted during close... not sooner like it's happening now.
Will change them to be created with new, make it not work and update.

Jul 4 2018, 2:39 AM · Frameworks

Jul 3 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

QTEST_MAIN already provides QApplication and event loop

Jul 3 2018, 12:17 PM · Frameworks

Jul 1 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Unit test is there... and it passes... always... with or without the kmainwindow.cpp patch :-/
Is there some simpler way to initialize/kill QApplication for each mainwindow creation/deletion, other than adding another unit test that uses QTEST_APPLESS_MAIN instead of QTEST_MAIN?

Jul 1 2018, 2:35 AM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Added unit test

Jul 1 2018, 2:24 AM · Frameworks

Jun 30 2018

maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

The change in qt affects when the window close event is handled in queue, it didn't change when it is fired. With qt 5.11.1 child widgets get destroyed a bit sooner, but it's still gets triggered by same close event - i think that stayed like it always was.
Also KMainWindow code is made to autosave settings (if not disabled) every time some relevant widget changes, so am pretty sure that this patch won't ever cause it to save incorrect settings.
Window/widget visibility and size is unlikely to change by user after they click to close window.

Jun 30 2018, 11:51 PM · Frameworks
maxrd2 added a comment to D13808: Fix KMainWindow saving incorrect widget settings.

Relative bug is here https://bugs.kde.org/show_bug.cgi?id=395988

Jun 30 2018, 9:57 AM · Frameworks
maxrd2 updated the diff for D13808: Fix KMainWindow saving incorrect widget settings.

Cleaned up indentation.

Jun 30 2018, 9:44 AM · Frameworks
maxrd2 requested review of D13808: Fix KMainWindow saving incorrect widget settings.
Jun 30 2018, 9:38 AM · Frameworks

Sep 7 2017

maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

Thanks, but do you know why the apps datasource doesn't have that entry after a while?

Sep 7 2017, 11:18 PM · Frameworks, Plasma

Sep 5 2017

maxrd2 added a comment to D7676: Added openService() method to KRunProxy.

Well it is now "openService" calling "runApplication", that's inconsistent isn't it

Sep 5 2017, 9:00 AM · Frameworks

Sep 4 2017

maxrd2 updated the diff for D7676: Added openService() method to KRunProxy.

Removed service->isApplication() check, improved method description.

Sep 4 2017, 4:23 PM · Frameworks

Sep 3 2017

maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

I don't have full developer account so i can't land this one. It also needs D7676 for this to work.

Sep 3 2017, 2:23 PM · Frameworks, Plasma
maxrd2 added inline comments to D7676: Added openService() method to KRunProxy.
Sep 3 2017, 2:15 PM · Frameworks
maxrd2 added a dependency for D7648: Fix ksysguard not starting on plasmoid click: D7676: Added openService() method to KRunProxy.
Sep 3 2017, 2:10 PM · Frameworks, Plasma
maxrd2 added a dependent revision for D7676: Added openService() method to KRunProxy: D7648: Fix ksysguard not starting on plasmoid click.
Sep 3 2017, 2:10 PM · Frameworks
maxrd2 added a comment to D7676: Added openService() method to KRunProxy.
Sep 3 2017, 2:09 PM · Frameworks
maxrd2 updated the diff for D7676: Added openService() method to KRunProxy.

Replaced runService() call with runApplication()

Sep 3 2017, 2:07 PM · Frameworks
maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

There it goes... updated the qml and added KRunProxy changes here: D7676

Sep 3 2017, 1:58 PM · Frameworks, Plasma
maxrd2 added a reviewer for D7676: Added openService() method to KRunProxy: davidedmundson.
Sep 3 2017, 1:56 PM · Frameworks
maxrd2 created D7676: Added openService() method to KRunProxy.
Sep 3 2017, 1:55 PM · Frameworks
maxrd2 updated the diff for D7648: Fix ksysguard not starting on plasmoid click.

Plasmoid uses KRun::openService() to launch ksysguard

Sep 3 2017, 1:50 PM · Frameworks, Plasma
maxrd2 updated the diff for D7648: Fix ksysguard not starting on plasmoid click.

Added KRun::openService() method

Sep 3 2017, 1:49 PM · Frameworks, Plasma
maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

Also seems KService::serviceByName() was removed from KF5.. so it's ok just to re-add it?
https://github.com/KDE/kservice/blob/master/src/services/kservice.h

Sep 3 2017, 1:03 PM · Frameworks, Plasma
maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

Great will make those changes/additions then.
Do you know why was KService::serviceByName() deprecated in KDE 4? (https://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/classKService.html#a2c5b00fd381b9843b6ba99da692c90ae)

Sep 3 2017, 1:00 PM · Frameworks, Plasma
maxrd2 removed a reviewer for D7648: Fix ksysguard not starting on plasmoid click: sars.
Sep 3 2017, 11:00 AM · Frameworks, Plasma
maxrd2 added a comment to D7648: Fix ksysguard not starting on plasmoid click.

Am not sure why apps.data["org.kde.ksysguard.desktop"] becomes undefined.
Think it might be a bug in PlasmaCore.DataSource? I haven't noticed any log messages apart that TypeError.

Sep 3 2017, 10:20 AM · Frameworks, Plasma
maxrd2 added a reviewer for D7648: Fix ksysguard not starting on plasmoid click: sars.
Sep 3 2017, 9:47 AM · Frameworks, Plasma

Sep 2 2017

maxrd2 moved T4683: Discussion: Templated objects in SVG from Needs usecases and ideas to Kickstarter Stretchgoals on the Krita: Next Features board.
Sep 2 2017, 12:41 AM · Krita: Next Features
maxrd2 moved T4683: Discussion: Templated objects in SVG from Kickstarter Stretchgoals to Needs usecases and ideas on the Krita: Next Features board.
Sep 2 2017, 12:41 AM · Krita: Next Features
maxrd2 created D7648: Fix ksysguard not starting on plasmoid click.
Sep 2 2017, 12:27 AM · Frameworks, Plasma