smb: apply a whole bunch of static analyzer improvements

Authored by sitter on Feb 25 2020, 11:44 AM.

Description

smb: apply a whole bunch of static analyzer improvements

Summary:
among other things:

  • {} initialize the posix structs
  • =default d/ctors where appropriate
  • synced argument names between header and cpp
  • no c-style casting
  • while(true) instead of while(1)
  • initialize class members that could previously have gone uninitialized
  • no single-line-multi-variable declaration

Test Plan: builds

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, kfm-devel

Tags: Dolphin, Frameworks

Differential Revision: https://phabricator.kde.org/D27646

Details

Committed
sitterFeb 26 2020, 11:13 AM
Reviewer
ngraham
Differential Revision
D27646: smb: apply a whole bunch of static analyzer improvements
Parents
R320:60c9ac5a089a: smb: throw out the windows variant of the slave
Branches
Unknown
Tags
Unknown