smb: apply a whole bunch of static analyzer improvements
ClosedPublic

Authored by sitter on Feb 25 2020, 11:44 AM.

Details

Summary

among other things:

  • {} initialize the posix structs
  • =default d/ctors where appropriate
  • synced argument names between header and cpp
  • no c-style casting
  • while(true) instead of while(1)
  • initialize class members that could previously have gone uninitialized
  • no single-line-multi-variable declaration
Test Plan

builds

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Feb 25 2020, 11:44 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptFeb 25 2020, 11:44 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Feb 25 2020, 11:44 AM
ngraham accepted this revision.Feb 25 2020, 4:00 PM
This revision is now accepted and ready to land.Feb 25 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.