After opening and switching to a new tab, always focus the view

Authored by ngraham on Jan 29 2019, 1:31 PM.

Description

After opening and switching to a new tab, always focus the view

Summary:
When Dolphin opens a new tab and immediately switches to it, the URL navigator gets focus if it's editable. If it's not, the breadcrumbs bar gets keyboard focus, which is not very useful since it's not really intended for keyboard navigation.

This patch changes that behavior so that the view always gets focus, which seems more useful and more consistent.

BUG: 401899
FIXED-IN: 19.04.0

Test Plan:

  1. Put the URL navigator into breadcrumbs mode
  2. Open a new tab
  3. Observe that the view gets keyboard focus
  4. Put the URL navigator into editable mode
  5. Open a new tab
  6. Observe that the view still gets keyboard focus

Reviewers: Dolphin, elvisangelaccio

Reviewed By: Dolphin, elvisangelaccio

Subscribers: emateli, elvisangelaccio, kfm-devel

Tags: Dolphin

Differential Revision: https://phabricator.kde.org/D17635

Details

Committed
ngrahamJan 29 2019, 1:33 PM
Reviewer
Dolphin
Differential Revision
D17635: After opening and switching to a new tab, always focus the view
Parents
R318:8bc93b564c28: Introduce HAVE_TERMINAL
Branches
Unknown
Tags
Unknown