Differential D19246

Refocus to main view when switching between tabs
AbandonedPublic
Actions

Authored by vpilo on Feb 23 2019, 9:21 AM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Summary

When the filter bar was open, switching between tabs put keyboard focus on it instead of on the main view.

Test Plan

Enable filter bar. Add a tab, switch to it, focus is on main view instead on filter bar.

Diff Detail

Repository
R318 Dolphin
Branch
vpilo/refocus (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8726
Build 8744: arc lint + arc unit
vpilo created this revision.Feb 23 2019, 9:21 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptFeb 23 2019, 9:21 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
vpilo requested review of this revision.Feb 23 2019, 9:21 AM
vpilo added a reviewer: Dolphin.EditedFeb 23 2019, 9:22 AM

I am not sure this is the right place for this.

I tried on DolphinView's constructor, in DolphinViewContainer::readSettings(), and in DolphinTabWidget::openNewTab(), but it doesn't fix the issue.

elvisangelaccio requested changes to this revision.Feb 24 2019, 12:20 PM
elvisangelaccio added subscribers: ngraham, elvisangelaccio.

Hmm, it seems to me that b7ceb51b44 already fixed this issue. I can reproduce it only if I revert this commit on master (@ngraham can you check?)

But anyway DolphinViewActionHandler is not the right place to set the focus, we need to figure out where and why the filter bar gets precedence in the focus chain.

This revision now requires changes to proceed.Feb 24 2019, 12:20 PM
ngraham added a comment.Feb 24 2019, 8:17 PM

Yeah, this already works for me with the current state of git master.

vpilo added a comment.Feb 26 2019, 5:27 PM
In D19246#418490, @elvisangelaccio wrote:

Hmm, it seems to me that b7ceb51b44 already fixed this issue. I can reproduce it only if I revert this commit on master (@ngraham can you check?)

But anyway DolphinViewActionHandler is not the right place to set the focus, we need to figure out where and why the filter bar gets precedence in the focus chain.

Awesome! One more papercut gone :) thanks!

vpilo abandoned this revision.Feb 26 2019, 5:27 PM

Revision Contents
Changeset List

Diff 52367

View Options

src/views/dolphinviewactionhandler.cpp

Loading...