WIP: Support for Remote Desktop Gateway
Needs ReviewPublic
Actions

Authored by scarpino on Jan 13 2018, 10:16 AM.

Details

Reviewers

jriddell
mdawson
wbauer
lueck

Summary

FEATURE: 281071
Support for Remote Desktop Gateway

Since this PR adds 4 more input fields, I refactored the UI to use tabs instead of a "single-column" widget.

I mark this as WIP, because the password should be saved into KWallet if it's enabled.

Test Plan

built and tested

Diff Detail

Repository

R436 KRDC

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

scarpino requested review of this revision.Jan 13 2018, 10:16 AM

scarpino created this revision.

scarpino edited the summary of this revision. (Show Details)Jan 13 2018, 10:17 AM

scarpino edited the summary of this revision. (Show Details)

scarpino retitled this revision from Support for Remote Desktop Gateway to WIP: Support for Remote Desktop Gateway.Jan 13 2018, 10:20 AM

scarpino edited the summary of this revision. (Show Details)

ngraham edited the summary of this revision. (Show Details)Jan 13 2018, 3:48 PM

Thanks for your work! Code looks good after a first short look into it. Can you share a screenshot how it looks with the new tab widget?

rdp/rdppreferences.cpp
41	Why is this not required anymore?
rdp/rdppreferences.ui
686	Are you sure this and the following lines are not required anymore?

Re-add tabstops

scarpino marked an inline comment as done.Jan 17 2018, 7:20 PM

scarpino added inline comments.

rdp/rdppreferences.ui
686	Thanks, this is an error indeed and I also have to add my new entries

scarpino marked an inline comment as done.Jan 17 2018, 7:21 PM

scarpino marked an inline comment as done.

New UI:

rdp/rdppreferences.cpp
41	I think this was an hack to display width/height fields properly under the resolution combobox.

scarpino marked an inline comment as done.Jan 17 2018, 7:26 PM

scarpino marked an inline comment as done.

Minor points I have noticed on screenshots:

add : after labels (before input) to be consistent with other places
probably explain at least once (e.g. in the tab title the full name for RD"?

Done:

BTW, I really don't know how to handle the RDpassword. I would like to store that into KWallet, but that is an 'host preference' for KRDC and the kwallet isn't accessible from that class. Should I implement it that way?

Fix labels

ngraham added a subscriber: ngraham.Jan 17 2018, 8:05 PM

BTW, I really don't know how to handle the RDpassword. I would like to store that into KWallet, but that is an 'host preference' for KRDC and the kwallet isn't accessible from that class. Should I implement it that way?

Yes, saving the passwords is the (only) valid option for this case.

i am no developer

Revision Contents
Changeset List

			Path	Packages
M			core/krdc.kcfg (12 lines)
M			rdp/rdphostpreferences.h (8 lines)
M			rdp/rdphostpreferences.cpp (50 lines)
M			rdp/rdppreferences.cpp (1 line)
M			rdp/rdppreferences.ui (1195 lines)
M			rdp/rdpview.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25262	e835305		Jan 13 2018, 10:16 AM	★	★
Diff 2	25555	e835305	Re-add tabstops	Jan 17 2018, 7:20 PM	★	★
Diff 3	25563	e835305	Fix labels	Jan 17 2018, 8:05 PM	★	★