Differential D9829

Don't create 2 msgbox (one of them crashes) when can't change rights
AbandonedPublic
Actions

Authored by jtamate on Jan 11 2018, 6:15 PM.

Details

Reviewers
anthonyfieroni
dfaure
Group Reviewers
Frameworks
Summary

When copying files in a filesystem where the permissions can not be
changed do not generate two dialogs and do not crash when pressing
"skip all".

This is the revival of https://phabricator.kde.org/D9005
Finally, it is needed.

Test Plan

Copying several files to a file system where the rights can't be changed,
two dialogs asking for "Retry Skip Skip all Abort" where shown.
Pressing Skip all crashed dolphin.
Now only one dialog is shown and no crash pressing skip all.

Diff Detail

Repository
R241 KIO
Branch
filecopy (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
jtamate created this revision.Jan 11 2018, 6:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 11 2018, 6:15 PM
jtamate requested review of this revision.Jan 11 2018, 6:15 PM
anthonyfieroni added a comment.Jan 11 2018, 6:47 PM

What is job->error() ?

jtamate added a comment.Jan 12 2018, 9:30 AM
In D9829#189580, @anthonyfieroni wrote:

What is job->error() ?

job->error()= 115 job->errorText= "/d/borrar/file.img" (the text is the target file path)

anthonyfieroni added a comment.Jan 12 2018, 3:20 PM

I'm still not sure that is correct fix. Can you investigate why second msgbox is shown? Maybe there is the problem.

anthonyfieroni added a comment.Feb 17 2018, 7:54 PM

What is state of this?

jtamate abandoned this revision.Mar 9 2018, 7:56 PM

With the changes in https://phabricator.kde.org/D10376 this patch is not needed.

Revision Contents
Changeset List

PathPackages
Msrc/core/filecopyjob.cpp (6 lines)

Diff 25178

View Options

src/core/filecopyjob.cpp

Loading...