Explore activities: Fix progress bar overriding on resizing
ClosedPublic

Authored by ganeshredcobra on Jan 3 2018, 5:44 PM.

Details

Summary

Explore activities: Fix progress bar overriding on resizing.

Moved the progress bar to right side to avoid hiding animals.
Changed the width and height to prevent size anomalies while resizing.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
ganeshredcobra created this revision.Jan 3 2018, 5:44 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 3 2018, 5:44 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

Moved the progress bar to right side.
Progress bar position changes dynamically with respect to vertical and horizontal mode
Changed the width and height of progress barto prevent size anomalies while resizing.
Changed the Y position on Cat.svg, so that it wont hide below progress bar.

jjazeix added inline comments.
src/activities/explore_farm_animals/ExploreLevels.qml
58

no need to add this, you already have horizontal just below that you can use.
Use a full name too instead of abbreviations

161

remove the space at the end

ganeshredcobra updated this revision to Diff 25341.EditedJan 14 2018, 8:03 PM

removed abbreviation of vertical layout
removed unnecessary space

ganeshredcobra marked 2 inline comments as done.

used horizontal layout and removed vertical layout
removed unnecessary space

  1. Animals still hide behind the bar.
  2. On vertical screens, the cat is overridden by the progress bar.
  3. For screen sizes just little wider than the horizontal layout, the progress bar is overridden by the bar.
src/activities/explore_farm_animals/ExploreLevels.qml
58

remove white-spaces

  1. Animals still hide behind the bar.
  2. On vertical screens, the cat is overridden by the progress bar.
  3. For screen sizes just little wider than the horizontal layout, the progress bar is overridden by the bar.

@amankumargupta Can you give a scrrenshot

Here is a screenshot.
for my computer the pig is behing the bar and a part of the cat also.

https://snag.gy/SlbKcp.jpg

ganeshredcobra updated this revision to Diff 27014.EditedFeb 12 2018, 5:05 PM

changed position of animals such that none of them is hidden

Vertical mode

https://pasteboard.co/H7kbr5R.png

Horizontal mode

https://pasteboard.co/H7kbLoH.png

amankumargupta added a comment.EditedFeb 14 2018, 6:43 AM

The progress bar still hides behind the bar:
https://pasteboard.co/H7yWT8Vw.png

and also some part of animal images also hides behind the bar in both, horizontal as well as vertical mode.

Can you reduce the height of all the animals just slightly so that the small change in height does not make much difference from the original size, and the totality of the screen is used as a result of aggregate reduction of sizes of each animal (this will also prevent animals hiding behind the bar as well)?

Thank you!

Hiding of progress bar avoided
Changed size and position of animals such none of them hides behind the bar

src/activities/explore_farm_animals/ExploreLevels.qml
59

missing spaces in progressbar.width/2

missing space added

The ok button that appears when you finish the level is behind the bar, can you please move it too?
You can reduce the height of the progress bar to "progressbarText.height" to gain some space.
I woudl let the progressbar above the bar even in horizontal mode: https://pasteboard.co/H8ekZD0.png

ganeshredcobra marked 2 inline comments as done.

Changed the position of OK button to top of bar.
Reduced the height of the progress bar to "progressbarText.height" .
Progress bar remains on top of the bar always.

There's one more thing which could be improved. When a level is completed and the user is shown OK button, clicking on animals is still allowed, and the bad face is shown: "check answer", for which I think clicking on animals can be disabled in this case as the level is over.

timotheegiet accepted this revision.Mar 11 2018, 7:36 PM
timotheegiet added a subscriber: timotheegiet.

Tested on desktop and phone, accepted and pushed.
About the last comment, it is true this could be improved, but I think it is outside the scope of this patch.

This revision is now accepted and ready to land.Mar 11 2018, 7:36 PM
timotheegiet closed this revision.Mar 11 2018, 7:37 PM