Explore activities: Fix progress bar overriding on resizing.
Moved the progress bar to right side to avoid hiding animals.
Changed the width and height to prevent size anomalies while resizing.
timotheegiet |
GCompris |
Explore activities: Fix progress bar overriding on resizing.
Moved the progress bar to right side to avoid hiding animals.
Changed the width and height to prevent size anomalies while resizing.
Lint Skipped |
Unit Tests Skipped |
Moved the progress bar to right side.
Progress bar position changes dynamically with respect to vertical and horizontal mode
Changed the width and height of progress barto prevent size anomalies while resizing.
Changed the Y position on Cat.svg, so that it wont hide below progress bar.
src/activities/explore_farm_animals/ExploreLevels.qml | ||
---|---|---|
58 | remove white-spaces |
Here is a screenshot.
for my computer the pig is behing the bar and a part of the cat also.
changed position of animals such that none of them is hidden
Vertical mode
https://pasteboard.co/H7kbr5R.png
Horizontal mode
The progress bar still hides behind the bar:
https://pasteboard.co/H7yWT8Vw.png
and also some part of animal images also hides behind the bar in both, horizontal as well as vertical mode.
Can you reduce the height of all the animals just slightly so that the small change in height does not make much difference from the original size, and the totality of the screen is used as a result of aggregate reduction of sizes of each animal (this will also prevent animals hiding behind the bar as well)?
Thank you!
Hiding of progress bar avoided
Changed size and position of animals such none of them hides behind the bar
src/activities/explore_farm_animals/ExploreLevels.qml | ||
---|---|---|
59 | missing spaces in progressbar.width/2 |
The ok button that appears when you finish the level is behind the bar, can you please move it too?
You can reduce the height of the progress bar to "progressbarText.height" to gain some space.
I woudl let the progressbar above the bar even in horizontal mode: https://pasteboard.co/H8ekZD0.png
Changed the position of OK button to top of bar.
Reduced the height of the progress bar to "progressbarText.height" .
Progress bar remains on top of the bar always.
There's one more thing which could be improved. When a level is completed and the user is shown OK button, clicking on animals is still allowed, and the bad face is shown: "check answer", for which I think clicking on animals can be disabled in this case as the level is over.
Tested on desktop and phone, accepted and pushed.
About the last comment, it is true this could be improved, but I think it is outside the scope of this patch.