Differential D9558

Show notifications that are present when pairing
ClosedPublic
Actions

Authored by nicolasfella on Dec 29 2017, 10:34 PM.

Details

Reviewers
mtijink
albertvaka
Group Reviewers
KDE Connect
Commits
R225:e94959f9c349: Show notifications that are present when pairing
Summary

When the plugin is created all current notifications are sent to the other device. When the NotificationListener is not ready at that time this is delayed until it is. This was intended before, but did not work because the
requestAnswer flag was set on the network packages. The desktop ignored those packages. I see no purpose for the requestAnswer flag so I removed it.

Depends on D9622

Test Plan

Create some notifications. Restart the desktop or the app and look for the notifications on the desktop

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Dec 29 2017, 10:34 PM
nicolasfella created this revision.
mtijink requested changes to this revision.Dec 30 2017, 1:17 PM
mtijink added a subscriber: mtijink.

Looks good, generally.

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java
95

Should be in onListenerConnected.

This revision now requires changes to proceed.Dec 30 2017, 1:17 PM
nicolasfella marked an inline comment as done.Jan 2 2018, 8:42 PM
nicolasfella updated this revision to Diff 24623.Jan 2 2018, 8:46 PM

Double oops

nicolasfella updated this revision to Diff 24633.Jan 2 2018, 10:18 PM

Separate real changes from refactoring

mtijink accepted this revision.Jan 3 2018, 7:11 PM

Looks good to me!

This revision is now accepted and ready to land.Jan 3 2018, 7:11 PM
albertvaka accepted this revision.Jan 6 2018, 1:52 PM
Closed by commit R225:e94959f9c349: Show notifications that are present when pairing (authored by nicolasfella). · Explain WhyJan 6 2018, 3:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24841

View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationReceiver.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

Loading...