Differential D9559

Remove unused code in NotificationDbusInterface
ClosedPublic
Actions

Authored by nicolasfella on Dec 29 2017, 11:02 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:d58f6cf2ae05: Remove unused code in NotificationDbusInterface
Summary

The isRequest codepath is never used. The requestAnswer path is not implemented and after D9558 not needed anymore.

Test Plan

Sending notifications works like before

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Dec 29 2017, 11:02 PM
nicolasfella created this revision.
albertvaka added a subscriber: albertvaka.Feb 17 2018, 10:33 AM
albertvaka added inline comments.
plugins/notifications/notificationsdbusinterface.cpp
67

Isn't this a typo and it should be "request" instead?

There is code on the Android side (ReceiveNotifications.java) that sends a "request" to receive all the current notifications.

nicolasfella added inline comments.Feb 20 2018, 7:55 PM
plugins/notifications/notificationsdbusinterface.cpp
67

It seems so. But I don't see why the Receive notificationsplugin (the phone) would ask the notificationsplugin (desktop) for it's notifications (they origin from the phone anyway). If anyone the sendnotifications plugin (desktop) should answer that request

albertvaka accepted this revision.Mar 4 2018, 10:19 AM

True, I thought these were the desktop notifications but they are not.

This revision is now accepted and ready to land.Mar 4 2018, 10:19 AM
Closed by commit R224:d58f6cf2ae05: Remove unused code in NotificationDbusInterface (authored by nicolasfella). · Explain WhyMar 4 2018, 12:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28580

View Options

plugins/notifications/notificationsdbusinterface.cpp

Loading...