Details
- Reviewers
mtijink - Group Reviewers
KDE Connect - Commits
- R225:d218a10004cf: Use minSdk in NotificationsPlugin
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Could you separate the real changes and the formatting changes? Or skip the formatting changes altogether? That makes reviewing easier 😃
| src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java | ||
|---|---|---|
| 417 | This line shouldn't be removed, as it's a different version check than the other code. | |
| 453 | Same here. | |
| 462–464 | Why was this version check introduced? That version is already required by the @RequiresApi annotation. | |
| 574 | Why Jelly Bean? As I understand the code, it should work with Kitkat. | |
| src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java | ||
|---|---|---|
| 417 | It's already checked before loading the plugin | |
| 462–464 | As far as I understand the Annotation is just to suppress warnings/show developers that a specific version is needed. We have to make sure ourself that replyToNotification isn't called. Correct me if I'm wrong | |
| 574 | NotificationListenerService requires 18/JELLY_BEAN_MR2, without this the whole Plugin doesn't make much sense. 20/KITKAT_WATCH is only needed for the reply feature | |