Differential D9550

Don't set the LD_LIBRARY_PATH in prefix.sh
ClosedPublic
Actions

Authored by apol on Dec 29 2017, 3:56 PM.

Details

Reviewers
dfaure
ngraham
graesslin
Group Reviewers
Frameworks
Commits
R240:34babd2ffc86: Don't set the LD_LIBRARY_PATH in prefix.sh
Summary

We already have rpaths anyway and it breaks running applications from
within the build directory:
https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Dec 29 2017, 3:56 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptDec 29 2017, 3:56 PM
Restricted Application added a subscriber: Build System. · View Herald Transcript
apol requested review of this revision.Dec 29 2017, 3:56 PM
ngraham accepted this revision.Dec 29 2017, 7:17 PM
ngraham added a subscriber: ngraham.

+1, LD_LIBRARY_PATH is the Dark Side. :-)

This revision is now accepted and ready to land.Dec 29 2017, 7:17 PM
dfaure added a comment.Dec 29 2017, 7:49 PM

Why leave it here, commented out, without explanations?
I'd either remove it completely, or explain the '#' ...

apol updated this revision to Diff 24473.Dec 29 2017, 8:16 PM

Explain

graesslin accepted this revision.Dec 29 2017, 9:18 PM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
kde-modules/prefix.sh.cmake
3–4

Just a note: this would break for Plasma/Wayland anyway. kwin_wayland has capabilities and thus LD_LIBRARY_PATH gets unset and is not available to the session.

Closed by commit R240:34babd2ffc86: Don't set the LD_LIBRARY_PATH in prefix.sh (authored by apol). · Explain WhyJan 28 2018, 10:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkde-modules/prefix.sh.cmake (4 lines)

Diff 24473

View Options

kde-modules/prefix.sh.cmake

Loading...