[kglobalaccel] Drop QWidget dependency
AbandonedPublic
Actions

Authored by anthonyfieroni on Nov 29 2017, 11:40 AM.

Details

Reviewers

davidedmundson
apol

Repository

R268 KGlobalAccel

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

QApplication is for widgets, so you should keep it a QGuiApplication and just remove the widgets dependency.

(The naming is confusing, indeed, it's QCoreApplication → QGuiApplication → QApplication)

davidedmundson requested changes to this revision.Nov 29 2017, 11:48 AM

davidedmundson added inline comments.

CMakeLists.txt
36	lib still uses widgets, I doubt this will compile. If it does, it's because it's pulled in from something else. (in fact the runtime links against them too, but for a hidden window to capture key events)
src/runtime/main.cpp
29 ↗	(On Diff #23126)	I don't understand, this would re-introduce a widgets dependency.

This revision now requires changes to proceed.Nov 29 2017, 11:48 AM

It compiles.

CMakeLists.txt
36	A depend has widgets on a public interface, i guess

graesslin added inline comments.

CMakeLists.txt
36	If KGlogalAccel needs Widgets, Widgets must stay.

QAction dependency cannot be dropped.

			Path	Packages
M			CMakeLists.txt (2 lines)