in drawPixmap(source, sourceRect) the source rect is in native pixels.
In this code the size was scaled by the DPR, but the location was not.
blendRect is the contents of a selection rectangle, offset from the
bounding darker blue rectangle. Hence we haven't really noticed.
This completely fixes the rectangle when the scale == 2.0/3.0
Some smaller artifacts remain on fractional scale factors, which is a
separate code bug with the same symptoms.
CCBUG: 386111
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| ui/pageview.cpp | ||
|---|---|---|
| 1783 | Are you sure there haven't parentheses over subtractions | |
@davidedmundson Could you confirm/refute Anthony's concern?
(I might be willing to try the patch afterwards.)
I tried the patch, and it did not fix 386111 for me. But I use fractional scaling, so maybe that's to be expected.
I also added the parentheses that one would expect in line 1708, but that didn't change anything.
Thanks David, I can confirm this stops the text from moving upon selection with the rectangle tool (Ctrl+3) for integer scaling factors. Code LGTM.
For the inline selection tool (Ctrl+4) as well as fractional scaling factors the issue remains, as you noted.
I'd say this can go to the stable branch.