Fix rubber band selection drawing contents misaligned with scaling

Authored by davidedmundson on Apr 9 2018, 9:58 PM.

Description

Fix rubber band selection drawing contents misaligned with scaling

Summary:
in drawPixmap(source, sourceRect) the source rect is in native pixels.

In this code the size was scaled by the DPR, but the location was not.
blendRect is the contents of a selection rectangle, offset from the
bounding darker blue rectangle. Hence we haven't really noticed.

This completely fixes the rectangle when the scale == 2.0/3.0

Some smaller artifacts remain on fractional scale factors, which is a
separate code bug with the same symptoms.

CCBUG: 386111

Reviewers: aacid, rkflx

Reviewed By: rkflx

Subscribers: sander, rkflx, anthonyfieroni, Okular

Tags: Okular

Differential Revision: https://phabricator.kde.org/D8980

Details

Committed
davidedmundsonApr 9 2018, 9:58 PM
Reviewer
rkflx
Differential Revision
D8980: Fix rubber band selection drawing contents misaligned with scaling
Parents
R223:0cb59caabbda: increase version to 1.4.x
Branches
Unknown
Tags
Unknown