Move power management checkbox to the top
ClosedPublic

Authored by ngraham on Nov 1 2017, 9:53 PM.

Details

Summary

BUG: 345940

Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 1 2017, 9:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2017, 9:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Nov 1 2017, 11:20 PM
davidedmundson added a subscriber: davidedmundson.

Generally, if we have a UI change can we include a screenshot - the one thing we really need to improve is the VDG being in continual feedback loops with regards to changes.

But +1 from me

This revision is now accepted and ready to land.Nov 1 2017, 11:20 PM

I would love to, and in general I do, but I do all my development in a VM, and my Neon VM doesn't expose a brightness setting, which is the control that inappropriately appears on top without this change. So the before-and-after wouldn't be very exciting. :) If anyone else wants to give it a whirl and post a screenshot, I would be very grateful.

I usually just temporarily mess with the dataengine to pretend to have brightness controls for testing :)

applets/batterymonitor/package/contents/ui/PopupDialog.qml
70

Can you make sure this is still correct?

To be quite honest I don't think there is a complete agreement on the layouts of the systray dialogues, although one should be considered - but since systray dialogues have a bit of a history and there are still plans going about another systray dialogue layout, we should be careful with adding work to current design.

ON THE OTHER HAND:
As long as the edits we plan are sort of careful we could create a unified ideal for the system tray popups with an eye towards eventual future edits. Is there an interest from a developer POV to create such a thing?

Say FOR EXAMPLE (an example, not a clear suggestion or goal) - we could design all popups to follow a simple layout like this https://imgur.com/a/xbGt1

mart added a subscriber: mart.Nov 2 2017, 12:49 PM

Let me explain the situation a bit: HIG for the systray content is in progress (and no, it won't be a complete redesign, but just a formalization of the best charateristic of the current plasmoids) so some modules *might* have to be partly reorganized afterwards.
an initial series of mockups is due soon on phabricator, so a discussion similar to the one on kcms can be done.

as for the immediate problem, moving the checkbox now may be good, if improves things as is a very small change. (it just may be necessary in the future to move again or make further changes even tough minor)

That's fine. I was just aiming for a small improvement here and to get a bug closed.

mart accepted this revision.Nov 2 2017, 12:57 PM

yeah, go for it for now

This revision was automatically updated to reflect the committed changes.