Differential D8486

Speed up .directory config loading
AbandonedPublic
Actions

Authored by davidedmundson on Oct 25 2017, 11:42 PM.

Details

Reviewers
emmanuelp
Group Reviewers
Dolphin
Summary

We don't need kdeglobals and full cascading for .directory files.

Test Plan

Checked dolphin still remembered whether I had previews enabled on a folder

Diff Detail

Repository
R318 Dolphin
Branch
singleappdolphin
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptOct 25 2017, 11:42 PM
apol added a subscriber: apol.Oct 26 2017, 12:44 AM

We don't? Isn't it a way to set default values for the directories?

broulik added a subscriber: broulik.Oct 26 2017, 8:25 AM

From what I can tell Dolphin has its own mechanism for "global" view properties, stored in ~/.local/share/dolphin/view_properties/global/ but I'm not sure how that cascades.

We're passing an absolute file path to KSharedConfig::openConfig anyway, so it looks like we only want that. You might still be able to influence that through kdeglobals, though.

davidedmundson abandoned this revision.Mar 19 2018, 9:13 PM

Revision Contents
Changeset List

PathPackages
Msrc/views/viewproperties.cpp (2 lines)

Diff 21344

View Options

src/views/viewproperties.cpp

Loading...