Required for 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm which concerns Wi-Fi settings of enterprise WPA/WPA2:
- TLS
- tunneled TLS
- PEAP
jgrulich |
Plasma |
Required for 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm which concerns Wi-Fi settings of enterprise WPA/WPA2:
BTW: To use the development build of the kcm module one must set QT_PLUGIN_PATH to the directory where kcm_networkmanagement.so has been installed. Then it can be tested by executing eg. kcmshell5 --desktopfile /devel/stuff/share/kservices5/plasma-applet-org.kde.plasma.networkmanagement.desktop kcm_networkmanagement.
Lint Skipped |
Unit Tests Skipped |
src/settings/security8021xsetting.h | ||
---|---|---|
66 | Usually these methods are named according to property they return so in this case it should be setDomainSuffixMatch() and domainSuffixMatch(). Same applies to other places where you use just domain. |
Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with "-DBUILD_TESTING=true" cmake command and then running "make tests" to verify your test passes.