Allow to set "domain-suffix-match" in Wi-Fi settings
ClosedPublic

Authored by Martchus on Oct 21 2017, 5:48 PM.

Details

Summary

This concerns Wi-Fi settings of enterprise WPA/WPA2:

  • TLS
  • tunneled TLS
  • PEAP

Requires commit Support "domain-suffix-match" in Security8021xSetting in networkmanager-qt (https://phabricator.kde.org/D8402).

Test Plan
  1. ApplySupport "domain-suffix-match" in Security8021xSetting` in networkmanager-qt as well
  2. Open connection settings
  3. Select Wi-Fi connection
  4. Configure domain under enterprise security settings
  5. Apply
  6. Open related config file, eg. /etc/NetworkManager/system-connections/eduroam
  7. Check whether "domain-suffix-match" is set correctly.

BTW: To use the development build of the kcm module one must set QT_PLUGIN_PATH to the directory where kcm_networkmanagement.so has been installed. Then it can be tested by executing eg. kcmshell5 --desktopfile /devel/stuff/share/kservices5/plasma-applet-org.kde.plasma.networkmanagement.desktop kcm_networkmanagement.

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Martchus created this revision.Oct 21 2017, 5:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptOct 21 2017, 5:48 PM

There's special syntax you can use to indicate the dependency in the Summary section:

"Depends on D8402"

Martchus retitled this revision from Allow to set "domain-suffix-match" in Wi-Fi settings to Depends on D8402 Allow to set "domain-suffix-match" in Wi-Fi settings.Oct 21 2017, 6:03 PM
Martchus retitled this revision from Depends on D8402 Allow to set "domain-suffix-match" in Wi-Fi settings to Allow to set "domain-suffix-match" in Wi-Fi settings.

It goes in the Summary, not the title, so you would replace "Requires commit Support "domain-suffix-match" in Security8021xSetting in networkmanager-qt (https://phabricator.kde.org/D8402)." with "Depends on D8402"

When doing that I'm getting the following error:

Unhandled Exception ("PhabricatorEdgeCycleException")
Graph cycle detected (type=5, cycle=PHID-DREV-pkm36mw773wvsopfgiic, PHID-DREV-4dp34miciioa53ocgthf, PHID-DREV-pkm36mw773wvsopfgiic).

So I'll better keep the full URL.

jgrulich requested changes to this revision.Oct 23 2017, 5:15 AM
jgrulich added a subscriber: jgrulich.

This looks good, you will just need to update it to reflect requested changes in your other review.

This revision now requires changes to proceed.Oct 23 2017, 5:15 AM
Martchus updated this revision to Diff 21150.Oct 23 2017, 6:08 AM

Adapt to updated D8402

jgrulich accepted this revision.Oct 23 2017, 6:39 AM

Good to go. Thank you.

This revision is now accepted and ready to land.Oct 23 2017, 6:39 AM

I don't have commit access so somebody needs to merge this for me.

This revision was automatically updated to reflect the committed changes.