Required for 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm which concerns Wi-Fi settings of enterprise WPA/WPA2:
- TLS
- tunneled TLS
- PEAP
Details
Details
- Reviewers
jgrulich - Group Reviewers
Plasma - Maniphest Tasks
- T7232: Allow specifying domain in plasma-nm Wi-Fi security settings
- Commits
- R282:7491ed93c8cb: Support "domain-suffix-match" in Security8021xSetting
- Apply 'Allow setting "domain-suffix-match" in Wi-Fi settings' in plasma-nm as well
- Open connection settings
- Select Wi-Fi connection
- Configure domain under enterprise security settings
- Apply
- Open related config file, eg. /etc/NetworkManager/system-connections/eduroam
- Check whether "domain-suffix-match" is set correctly.
BTW: To use the development build of the kcm module one must set QT_PLUGIN_PATH to the directory where kcm_networkmanagement.so has been installed. Then it can be tested by executing eg. kcmshell5 --desktopfile /devel/stuff/share/kservices5/plasma-applet-org.kde.plasma.networkmanagement.desktop kcm_networkmanagement.
Diff Detail
Diff Detail
- Repository
- R282 NetworkManagerQt
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/settings/security8021xsetting.h | ||
|---|---|---|
| 66 | Usually these methods are named according to property they return so in this case it should be setDomainSuffixMatch() and domainSuffixMatch(). Same applies to other places where you use just domain. | |
Comment Actions
Now it looks good. Just one thing I forgot is a unit test for this property. You can add it to autotests/settings/8021xsettingtest.cpp and build the tests with "-DBUILD_TESTING=true" cmake command and then running "make tests" to verify your test passes.