Add option to change Oxygen's windows decoration shadow intensity
AcceptedPublic
Actions

Authored by rpelorosso on Oct 18 2017, 7:21 PM.

Details

Reviewers

broulik
aacid
abetts

Group Reviewers

VDG

Summary

This patch solves the following problem: In order to obtain light shadows, the inner color should be changed to a light gray, resulting in light shadows that work well over lighter backgrounds, but look like glowing over darker backgrounds. The following screenshot shows this situation:

In order to allow having light shadows that behave as shadows over darker backgrounds I've introduced a new option for setting the overall shadow intensity. This value defaults to 100%, making shadows behave as they did prior to this patch.

With this new option, light shadows can be obtained setting the inner color to black and the intensity to a low value. Here's how it looks with an intensity of 50%.

Test Plan

Change the intensity value and see shadows become more or less intense (alpha value changing)

Diff Detail

Repository

R113 Oxygen Theme

Lint

Lint Skipped

Unit

Unit Tests Skipped

rpelorosso created this revision.Oct 18 2017, 7:21 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2017, 7:21 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

rpelorosso edited the summary of this revision. (Show Details)Oct 18 2017, 7:23 PM

rpelorosso retitled this revision from Add option to change windows shadow intensity to Add option to change Oxygen's windows decoration shadow intensity.Oct 18 2017, 7:26 PM

ngraham added a subscriber: ngraham.Oct 18 2017, 7:39 PM

rpelorosso added a reviewer: VDG.Oct 19 2017, 1:03 PM

@ngraham Sorry to bother you, but I'm fairly new to this process. As this hasn't gotten any attention, is there any other group that might want to review this beside VDG? (or is it just that there's no interest in something like this? Thanks!

VDG is pretty quiet lately. Not much movement may mean that nobody is very excited, but it also means that nobody has a serious objection. :) Let's add a few more reviewers and see if anyone has any opinions. I think @aacid uses Oxygen full time.

In D8361#159058, @rpelorosso wrote:

I'm fairly new to this process. As this hasn't gotten any attention, is there any other group that might want to review this beside VDG?

In general you could use git blame locally or in Phabricator and have a look at the commit history for non-trivial commits. You'll probably find you could add the same reviewer as I added to your other Diff (D8232).

@abetts, what do you think?

I like this change, I think it makes sense. However, if there is a way to know that the user "means" to use shadow then lets do this. If the user means to do "glow" this behavior should stay.

This revision is now accepted and ready to land.Nov 8 2017, 1:42 AM

Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes would be more intuitive here.

In D8361#165580, @ngraham wrote:

Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes would be more intuitive here.

That's what I mean.

In D8361#165581, @abetts wrote:

In D8361#165580, @ngraham wrote:

Yeah, maybe a combobox toggling between Glow and Shadow styles/blending modes would be more intuitive here.

That's what I mean.

I hadn't thought of that, but it's actually a good idea.

Revision Contents
Changeset List

			Path	Packages
M			liboxygen/oxygenactiveshadowconfigdata.kcfg (4 lines)
M			liboxygen/oxygeninactiveshadowconfigdata.kcfg (4 lines)
M			liboxygen/oxygenshadowcache.cpp (15 lines)
M			liboxygen/oxygenshadowconfigwidget.cpp (7 lines)
M			liboxygen/ui/oxygenshadowconfigurationui.ui (22 lines)