Make Qt5::X11Extras really optional
ClosedPublic

Authored by kfunk on Oct 15 2017, 12:19 PM.

Details

Summary

Otherwise may fail with:

CMake Warning at CMakeLists.txt:32 (find_package):
  Found package configuration file:

/Users/kfunk/Qt5.6.2/5.6/clang_64/lib/cmake/Qt5/Qt5Config.cmake

  but it set Qt5_FOUND to FALSE so package "Qt5" is considered to be NOT
  FOUND.  Reason given by package:

...

  Failed to find Qt5 component "X11Extras" config file at
  "/Users/kfunk/Qt5.6.2/5.6/clang_64/lib/cmake/Qt5X11Extras/Qt5X11ExtrasConfig.cmake" CMake Error at /usr/local/Cellar/cmake/3.6.2/share/cmake/Modules/FeatureSummary.cmake:556 (message):
  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake
  run.

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Oct 15 2017, 12:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 15 2017, 12:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Oct 15 2017, 12:50 PM
This revision is now accepted and ready to land.Oct 15 2017, 12:50 PM
apol added a subscriber: apol.Oct 15 2017, 1:43 PM
apol added inline comments.
CMakeLists.txt
33

Is this change needed?

sitter accepted this revision.Oct 15 2017, 3:46 PM
sitter added inline comments.
CMakeLists.txt
33

Don't think this makes a difference. From a cmake POV the new version is more correct though as Qt5 was already found so only finding Qt5X11Extras on its own seems more appropriate.

rjvbb added inline comments.Oct 15 2017, 3:47 PM
CMakeLists.txt
33

I don't understand, since when has DrKonqi been split out of plasma-runtime?

Plasma-runtime had a different approach: search for X11Extras only when X11 was found. I think that's the better approach; keep it obligatory with X11 (if there's a reason for that), don't bother to look for it when building for another platform.

This revision was automatically updated to reflect the committed changes.