Autosave popup notification for canvas-only mode
ClosedPublic

Authored by kdmitriy on Oct 14 2017, 3:07 PM.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kdmitriy created this revision.Oct 14 2017, 3:07 PM
Restricted Application added a subscriber: woltherav. · View Herald TranscriptOct 14 2017, 3:07 PM
kdmitriy updated this revision to Diff 20752.Oct 14 2017, 4:54 PM

neat feature... I don't know if we should have this on by default though. Canvas-only mode is designed to be as distraction free as possible. Saving is something that happens automatically in the background without any user input or action. The purpose of on-canvas messages are that they are triggered only with user initiated actions.

By default, Krita auto-saves every 15 minutes. I don't know if I want a message popping up every 15 minutes while I am in the middle of trying to draw.

Hi, @scottpetrovic!

By default, Krita auto-saves every 15 minutes. I don't know if I want a message popping up every 15 minutes while I am in the middle of trying to draw.

That was an issue reported by @Bollebib in T7070. He said that having a message telling his Krita is busy autosaving would be nice. But default the message is shown only in "statusbar-free" and fullscreen modes. Technically, we can reduce the timeout of the message box if needed.

rempt added a subscriber: rempt.Oct 14 2017, 7:52 PM

I really like the idea, though -- it is not very distracting, but it _is_ reassuring. Actually, I might be in favour of having it like this always, not just in canvas-only mode.

In D8297#155479, @rempt wrote:

I really like the idea, though -- it is not very distracting, but it _is_ reassuring. Actually, I might be in favour of having it like this always, not just in canvas-only mode.

There is a config option to make it "always visible", so we can ask the users to test it and if they like it, just make a default

dkazakov accepted this revision.Oct 14 2017, 8:31 PM

Okay, the patch seems to work as declared. I'll push it now, and after the painters give some input we might change the default settings.

This revision is now accepted and ready to land.Oct 14 2017, 8:31 PM
This revision was automatically updated to reflect the committed changes.

yes. I am ok with going that route. From my perspective...auto-saving is something that should just work without bringing it to my attention a lot. If a lot of other artists want to have that message, I would be ok with having it being on by default.