Differential D8259

Really fix appdata location
ClosedPublic
Actions

Authored by heikobecker on Oct 12 2017, 9:00 AM.

Details

Reviewers
rdieter
arojas
cfeck
Group Reviewers
KDE Games
Commits
R423:063e98089738: Really fix appdata location
Summary

7db6c1f5081f65f55ee7da065148b1b15272e22c broke installation, because
SHARE_INSTALL_DIR is nowhere defined.
The previous DATA_INSTALL_DIR is defined as "share/apps" which indeed
isn't correct either. SHARE_INSTALL_*PREFIX* exists and points to
"${CMAKE_INSTALL_PREFIX}/share" by default.

Diff Detail

Repository
R423 Palapeli
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Oct 12 2017, 9:00 AM
cfeck accepted this revision.Oct 12 2017, 9:07 AM
This revision is now accepted and ready to land.Oct 12 2017, 9:07 AM
Closed by commit R423:063e98089738: Really fix appdata location (authored by heikobecker). · Explain WhyOct 12 2017, 9:17 AM
This revision was automatically updated to reflect the committed changes.
lueck added a subscriber: lueck.Oct 12 2017, 10:18 AM

why not use KDE_INSTALL_METAINFODIR?

arojas added a comment.Oct 12 2017, 10:19 AM
In D8259#154575, @lueck wrote:

why not use KDE_INSTALL_METAINFODIR?

That's in ECM, palapeli is still KDE4 in 17.08

rdieter added a comment.Oct 12 2017, 12:46 PM

Sorry about the botch there, not sure how that ever worked for me. Thanks for fixing it.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (2 lines)

Diff 20630

View Options

src/CMakeLists.txt

Loading...