Some source-based distributions remove the translated artifacts
or make them optional depending on some flag. This change makes
sure that the compilation does not fail if po/ is removed.
(the other macros like ki18n_install, kdoctools_install, etc,
already behave as noop if the directory does not exist).
Details
Details
Regenerate a package with localized data (I tried step);
instead of the line add_subdirectory(po) the main CMakeLists.txt
file contains the new lines.
Diff Detail
Diff Detail
- Repository
- R497 Release tools
- Branch
- Applications/17.08
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Looks good, though maybe this is something we want for master in case it breaks it'll break with the 17.12 betas not with 17.08.2?
Comment Actions
Just for the record, I feel that it should be safe enough for 17.08 (warning, incoming brain dump):
- the change from add_subdirectory to ecm_optional_add_subdirectory, when the directory exists, should produce the same behavior;
- the more problematic part may be include(ECMOptionalAddSubdirectory); from what I understand, it should not be a problem to put it at the end of cmake, even if it is already included. Also, all applications using this depends on ECM.
Comment Actions
@cfeck I won't be around to do the 17.08.2 tagging since i'm flying that day, so i guess i'm going to let you decide if we're fine with this being in for 17.08.x or not
Comment Actions
I am fine. This isn't the first time we shipped broken l10n stuff in stable releases :)
Jokes aside, I trust Luigi to fix any regression we find.