Cosmetic dock title prefs
AbandonedPublic

Authored by rempt on Sep 27 2017, 9:26 AM.

Details

Reviewers
dkazakov
poke1024
Group Reviewers
Krita
Summary

This is about being able to configure the dock title appearance. It adds two new settings:

[GUI]
showpalettetitles=false
smallpalettefonts=true

Krita looks like this by default on OS X:


Yet having large palette fonts looks much more consistent and nicer, I believe:

For a minimal design, I think it also makes sense to completely hide the titles (while keeping the brush names big):

The latter version gives a cleaner look when using undocked palettes.

I wonder if this is something other users (apart from me) might like to set.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
poke1024 created this revision.Sep 27 2017, 9:26 AM
rempt added a subscriber: rempt.Sep 27 2017, 9:36 AM

Hm... I haven't got strong opinions here, but I wonder whether the empty title bar patch is necessary given that we can already hide the complete titlebar? Likewise with the docker font, I see that Corel Painter also uses a smaller font for the dockers than the rest of the UI, so I wonder what apple's ux guidelines say?

poke1024 edited the summary of this revision. (Show Details)Sep 27 2017, 9:38 AM

But hiding the title bar breaks moving the window in undocked move as far as I tried it once.

The one Apple guideline I'm aware of is this: https://developer.apple.com/ios/human-interface-guidelines/visual-design/typography/. Basically this tends to suggest you minimize typefaces and size variants. But with this PR, it's really very subjective, I guess.

Just for completeness' sake: what this ultimately aims at is a very minimal look like with Sketchbook Pro:

The docker looks a bit "unusual" when I set 'smallpalettefonts' to false. But let the user decide.

I would also propose to make the titles hidden automatically as soon as the docker becomes docked and show them back when they are undocked.

Lets ask @scottpetrovic!

Scott, could you answer two questions?

  1. Show we activate 'smallpalettefonts' on OSX by default? (And keep it off on all the other systems)
  2. Show we auto-hide the docker names when docked? And if yes, should this options be on by default?
libs/widgets/KoDockWidgetTitleBar_p.h
65

please mind the indentation style, phabricator doesn't handle tabs correctly :)

rempt added a comment.Oct 3 2017, 3:00 PM

As long as you don't mean "hide the titlebar", then yes, I agree that we shouldn't show the title text in the titlebar of docked dockers.

I am ok with the font size thing for OSX.

Hiding the title bar I think is going to be creating confusion. The title name is not shown anywhere else on the UI and it doesn't save any space by removing it. If a person isn't seeing a title, they have no way of knowing how to bring back a docker if it is closed (or what to call it if they want to refer to it). This is especially hard with color picker dockers since there are so many of them. This is really helpful for documentation and training as well.

Sketchbook is a minimal drawing program compared with krita in terms of functionality. I think they can get away with having a more minimal UI. If we want a more minimal default UI, we will need to create a workspace that would just have a lot less dockers shown. Of course... people will also think Krita can't do very much if we hide more dockers. A lot of people I see on Youtube still don't realize there is a tool options docker for each tool. You cannot see it when Krita starts, and of course people don't read and try to learn software before they do a review.

I am not saying we cannot add it...but I just don't think it should be on by default.

I do think the other hide title bar functionality does break some things. If we do add @poke1024 version ...I would opt to remove that old hide title bar behavior and replace it with what @poke1024 has. I think having two versions that are slightly different is confusing. I personally wouldn't use what @poke1024 has, but I do like it more than the current hide title bar functionality.

rempt added a comment.Oct 3 2017, 3:33 PM

Hm, if docks are tabbed, the title is also shown in the tab, so it needn't be shown in the titlebar, I guess. But that adds an extra prerequisite to hiding the title: the docker should be docked and in a row with tabs. Not sure whether we can detect that.

But at least on Windows, the dockers can't be undocked by dragging on the tab itself. One needs to drag on the title bar or click on the undock button.

rempt added a comment.Oct 3 2017, 3:38 PM

But at least on Windows, the dockers can't be undocked by dragging on the tab itself. One needs to drag on the title bar or click on the undock button.

Yes -- the titlebar itself needs to be visible when the docker is docked. It just doesn't need to have text in it, if the same text is also shown in the tabs. But we're really fighting Qt here, which is always a losing proposition. I have sworn we would never, ever have our own dockwidget/palette widget implementation ever again! (We have had two or three, in the early years, including one that could dock against the inside of the window decoration and pop out inside the window.)

rempt added a comment.Oct 3 2017, 3:38 PM

But at least on Windows, the dockers can't be undocked by dragging on the tab itself. One needs to drag on the title bar or click on the undock button.

Yes -- the titlebar itself needs to be visible when the docker is docked. It just doesn't need to have text in it, if the same text is also shown in the tabs. But we're really fighting Qt here, which is always a losing proposition. I have sworn we would never, ever have our own dockwidget/palette widget implementation ever again! (We have had two or three, in the early years, including one that could dock against the inside of the window decoration and pop out inside the window.)

As far as I can tell from the discussion, we agreed on something like that:

  1. The patch itself is fine, and can be pushed, unless you want to make "hide the title text" option to be the default
  2. We would really like to have an "auto-hide title text" feature, which would hide the text as soon as the docker gets docked and unhide the text when it gets undocked (like in your patch D8172)
  3. If you decide to go on with option 2), then the option "showpalettetitles' is not needed. We can enable it all the time.
rempt added a comment.Oct 9 2017, 12:23 PM
  1. We would really like to have an "auto-hide title text" feature, which would hide the text as soon as the docker gets docked and unhide the text when it gets undocked (like in your patch D8172)

Well, the titlebar should only have text if

  • it's docked
  • and not in a row of tabs with other docks
dkazakov requested changes to this revision.Oct 23 2017, 12:45 PM

I will mark this patch as Needs Changes, so it doesn't show up in the "Must review" list :)

This revision now requires changes to proceed.Oct 23 2017, 12:45 PM
rempt commandeered this revision.Apr 22 2019, 12:19 PM
rempt added a reviewer: poke1024.
Restricted Application added a project: Krita. ยท View Herald TranscriptApr 22 2019, 12:19 PM
rempt abandoned this revision.Apr 22 2019, 12:19 PM